Feature/uss/copy #2004

KutluOzel-b · 2022-11-09T07:56:03Z

Proposed changes

Adds multiselect copy / paste feature to uss view

Release Notes

#1549

Milestone:

Changelog:

Types of changes

Bugfix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[ x] I have read the CONTRIBUTOR GUIDANCE wiki
[ x] PR title follows Conventional Commits Guidelines
[ x] PR Description is included
gif or screenshot is included if visual changes are made
[ x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
All checks have passed (DCO, Jenkins and Code Coverage)
[ x] I have added unit test and it is passing
I have added integration test and it is passing
There is coverage for the code that I have added
[ x] I have tested it manually and there are no regressions found
I have added necessary documentation (if appropriate)
Any PR dependencies have been merged and published (if appropriate)

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

into feature/uss/copy

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

codecov · 2022-11-09T07:58:20Z

Codecov Report

Base: 74.49% // Head: 74.63% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (d85d3bc) compared to base (5c862dc).
Patch coverage: 88.31% of modified lines in pull request are covered.

❗ Current head d85d3bc differs from pull request most recent head 7117c10. Consider uploading reports for the commit 7117c10 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2004      +/-   ##
==========================================
+ Coverage   74.49%   74.63%   +0.13%     
==========================================
  Files          63       63              
  Lines        7341     7415      +74     
  Branches     1584     1601      +17     
==========================================
+ Hits         5469     5534      +65     
- Misses       1871     1880       +9     
  Partials        1        1

Impacted Files	Coverage Δ
packages/zowe-explorer/src/extension.ts	`37.38% <33.33%> (-0.05%)`	⬇️
packages/zowe-explorer/src/uss/actions.ts	`82.27% <89.47%> (+1.39%)`	⬆️
packages/zowe-explorer/src/uss/ZoweUSSNode.ts	`94.64% <96.55%> (+0.16%)`	⬆️
packages/zowe-explorer/src/globals.ts	`91.30% <100.00%> (ø)`
packages/zowe-explorer/src/uss/utils.ts	`88.23% <100.00%> (+2.52%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

JillieBeanSim

Hey @KutluOzel-b I commented on a couple things that need to be changed

JillieBeanSim · 2022-11-28T17:03:18Z

packages/zowe-explorer-api/CHANGELOG.md

@@ -11,6 +11,10 @@ All notable changes to the "zowe-explorer-api" extension will be documented in t

 ## `2.4.0`

+## TBD Release


this should be above the latest release tag

JillieBeanSim · 2022-11-28T17:03:39Z

packages/zowe-explorer-api/package.json

@@ -1,6 +1,6 @@
 {
  "name": "@zowe/zowe-explorer-api",
-  "version": "2.5.0-SNAPSHOT",
+  "version": "2.6.0-SNAPSHOT",


this needs to be reverted back to 2.5.0-SNAPSHOT

JillieBeanSim · 2022-11-28T17:04:04Z

packages/zowe-explorer-ftp-extension/package.json

@@ -47,7 +47,7 @@
    "vscode": "^1.53.2"
  },
  "dependencies": {
-    "@zowe/zowe-explorer-api": "2.5.0-SNAPSHOT",
+    "@zowe/zowe-explorer-api": "2.6.0-SNAPSHOT",


same with revert to 2.5.0-SNAPSHOT

JillieBeanSim · 2022-11-28T17:04:32Z

packages/zowe-explorer/CHANGELOG.md

@@ -16,6 +16,10 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen

 ## `2.4.0`

+## TBD Release


move CHANGELOG above the latest release tag

JillieBeanSim · 2022-11-28T17:05:00Z

packages/zowe-explorer/package.json

@@ -1736,7 +1776,7 @@
    "@types/promise-queue": "^2.2.0",
    "@types/selenium-webdriver": "^3.0.4",
    "@types/yargs": "^11.0.0",
-    "eslint-plugin-zowe-explorer": "2.5.0-SNAPSHOT",
+    "eslint-plugin-zowe-explorer": "2.6.0-SNAPSHOT",


2.5.0-SNAPSHOT

JillieBeanSim · 2022-11-28T17:05:10Z

packages/zowe-explorer/package.json

@@ -1776,7 +1816,7 @@
    "webpack-cli": "^3.3.11"
  },
  "dependencies": {
-    "@zowe/zowe-explorer-api": "2.5.0-SNAPSHOT",
+    "@zowe/zowe-explorer-api": "2.6.0-SNAPSHOT",


2.5.0-SNAPSHOT

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

KutluOzel-b · 2022-11-29T08:02:20Z

@JillieBeanSim Thanks for reviewing and feedbacks. Adressed all in : 767a703

Signed-off-by: Kutlu <104970275+KutluOzel-b@users.noreply.github.com>

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

JillieBeanSim

while testing, if I haven't copied anything and right-click on a directory and select paste the status bar mentions uploading but nothing is actually created. If I paste into a directory with file name already existing that I copied it automatically overwrites without notifying the user and allowing them to rename the file/folder and since the option is there even if folder is closed, this would be a good check to have.

I would still like to research if we can find a way to check the vsc clipboard and only offer paste if something is in there.

JillieBeanSim · 2022-12-09T16:32:19Z

packages/zowe-explorer/src/extension.ts

@@ -873,7 +886,7 @@ function initSubscribers(context: vscode.ExtensionContext, theProvider: IZoweTre
    }
 }

-function getSelectedNodeList(node: IZoweTreeNode, nodeList: IZoweTreeNode[]): IZoweTreeNode[] {
+export function getSelectedNodeList(node: IZoweTreeNode, nodeList: IZoweTreeNode[]): IZoweTreeNode[] {


@KutluOzel-b this function seems to be a duplicate of getSelectedNodeList() in shared/utils? We should only have one of these functions especially if they are exactly the same and I would suggest having it stay in the shared/utils file vs adding more to the extension.ts file.

@JillieBeanSim Thanks for the warning. This is caused by pulling from main branch. Keeping it in shared/utils

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

packages/zowe-explorer/src/uss/ZoweUSSNode.ts

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

…ension-for-zowe into feature/uss/copy

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

traeok · 2022-12-12T13:39:08Z

I tested these changes and I'm able to copy files now on Windows 👍 Thanks for looking into that issue! I might have found an edge case - copying an empty directory into another directory. If a folder has files inside, I can copy it into another directory, but in the case of an empty folder nothing happens. No exceptions occur, but the directory structure remains the same.

It's unlikely that a user would want to copy an empty directory into another directory when they can just right-click the parent -> "Create Directory" - but just wanted to mention it.

KutluOzel-b · 2022-12-12T14:01:14Z

I tested these changes and I'm able to copy files now on Windows 👍 Thanks for looking into that issue! I might have found an edge case - copying an empty directory into another directory. If a folder has files inside, I can copy it into another directory, but in the case of an empty folder nothing happens. No exceptions occur, but the directory structure remains the same.

It's unlikely that a user would want to copy an empty directory into another directory when they can just right-click the parent -> "Create Directory" - but just wanted to mention it.

Thanks @traeok for re-reviewing it and testing. I also hit this case and right now we don't have an api that checks if this directory is created on mf side, so decided to leave as it is and to be resolved when such Api is available/ or do this all operation on mf side . If copy paste is called after directory/node refresh it works. But again : this brings a needless and annoying refresh :/ since we can't decide to call refresh or not with lack of api.

t1m0thyj

Thanks for fixing the issues with copying on Windows 🙂

A few questions regarding the implementation:

When you right-click on a USS directory, should the menu item say "Copy Directory" instead of "Copy Files"?
If I have loaded directory /a in the USS tree that contains a subdirectory b, I don't see a way to create a copy of /a/b at the same level (/a/b (copy)). Should we add "Paste" to the right-click menu for the root USS node?

changes made and approvals in

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

Signed-off-by: Kutlu <104970275+KutluOzel-b@users.noreply.github.com>

sonarqubecloud · 2022-12-13T17:09:51Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.6% Duplication

KutluOzel-b added 7 commits November 7, 2022 11:39

copy local files & upload copies to mainframe

d3cb664

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

merge main

066b718

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

add unit tests

c6b0da6

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

Merge branch 'main' of https://github.com/zowe/vscode-extension-for-zowe

9841d37

into feature/uss/copy

modified changelog

3f7d91b

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

resolved lint issues

7c8837a

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

fix correct changelog

974245e

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

KutluOzel-b added 5 commits November 9, 2022 08:58

fix correct changelog

81e5357

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

removed duplications on tests

9f03414

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

removed unused imports

31dd637

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

removed unused tests

0858284

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

removed mistakenly written line on changelog

43e0d69

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

KutluOzel-b linked an issue Nov 9, 2022 that may be closed by this pull request

Copy/Paste and Multiple USS Files #1549

Closed

KutluOzel-b requested review from zFernand0 and JillieBeanSim November 9, 2022 12:24

KutluOzel-b and others added 4 commits November 9, 2022 14:34

add changelog updated explorer api version

6c7c957

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

add changelog updated explorer api version

0647d2d

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

revert changelog for es lint

08f786b

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

Merge branch 'main' into feature/uss/copy

c77658b

JillieBeanSim added this to the 2.5.0 milestone Nov 15, 2022

Merge branch 'main' into feature/uss/copy

288efac

JillieBeanSim requested changes Nov 28, 2022

View reviewed changes

adressed comments

767a703

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

KutluOzel-b and others added 5 commits November 29, 2022 11:40

Merge branch 'main' into feature/uss/copy

5800a88

Signed-off-by: Kutlu <104970275+KutluOzel-b@users.noreply.github.com>

fix download async & add progress bar

2d71a28

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

modified tests

ff749bc

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

lint issues adressed

804ca81

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

modified testes

1504763

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

KutluOzel-b and others added 3 commits December 8, 2022 15:15

make codecov happy

9b2e5ae

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

merge main

3c9213b

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

Merge branch 'main' into feature/uss/copy

d96dbbf

JillieBeanSim previously requested changes Dec 9, 2022

View reviewed changes

Merge branch 'main' into feature/uss/copy

612001f

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

t1m0thyj requested changes Dec 9, 2022

View reviewed changes

packages/zowe-explorer/src/uss/ZoweUSSNode.ts Outdated Show resolved Hide resolved

packages/zowe-explorer/src/uss/ZoweUSSNode.ts Outdated Show resolved Hide resolved

packages/zowe-explorer/src/uss/ZoweUSSNode.ts Outdated Show resolved Hide resolved

KutluOzel-b added 4 commits December 12, 2022 10:26

adressed windows problem

f0b0783

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

Merge branch 'feature/uss/copy' of https://github.com/zowe/vscode-ext…

4f79698

…ension-for-zowe into feature/uss/copy

removed duplicated method of getSelectedNodeList

8b1237f

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

fix tests

efb52cc

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

traeok previously approved these changes Dec 12, 2022

View reviewed changes

t1m0thyj previously approved these changes Dec 13, 2022

View reviewed changes

JillieBeanSim and others added 2 commits December 13, 2022 10:55

Merge branch 'main' into feature/uss/copy

b38def4

modified copy label in context menun

1cdd32c

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>

KutluOzel-b dismissed stale reviews from t1m0thyj and traeok via 1cdd32c December 13, 2022 16:31

JillieBeanSim requested review from t1m0thyj and traeok December 13, 2022 16:48

Merge branch 'main' into feature/uss/copy

d85d3bc

Signed-off-by: Kutlu <104970275+KutluOzel-b@users.noreply.github.com>

t1m0thyj mentioned this pull request Dec 13, 2022

Support pasting at top level of USS tree #2041

Closed

traeok approved these changes Dec 13, 2022

View reviewed changes

Merge branch 'main' into feature/uss/copy

7117c10

t1m0thyj approved these changes Dec 13, 2022

View reviewed changes

JillieBeanSim merged commit a5c12f1 into main Dec 13, 2022

JillieBeanSim deleted the feature/uss/copy branch December 13, 2022 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/uss/copy #2004

Feature/uss/copy #2004

KutluOzel-b commented Nov 9, 2022

codecov bot commented Nov 9, 2022 •

edited

Loading

JillieBeanSim left a comment

JillieBeanSim Nov 28, 2022 •

edited

Loading

JillieBeanSim Nov 28, 2022

JillieBeanSim Nov 28, 2022

JillieBeanSim Nov 28, 2022 •

edited

Loading

JillieBeanSim Nov 28, 2022

JillieBeanSim Nov 28, 2022

KutluOzel-b commented Nov 29, 2022

JillieBeanSim left a comment •

edited

Loading

JillieBeanSim Dec 9, 2022

KutluOzel-b Dec 12, 2022

traeok commented Dec 12, 2022 •

edited

Loading

KutluOzel-b commented Dec 12, 2022

t1m0thyj left a comment

sonarqubecloud bot commented Dec 13, 2022

		@@ -11,6 +11,10 @@ All notable changes to the "zowe-explorer-api" extension will be documented in t

		## `2.4.0`

		## TBD Release

		@@ -16,6 +16,10 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen

		## `2.4.0`

		## TBD Release

Feature/uss/copy #2004

Feature/uss/copy #2004

Conversation

KutluOzel-b commented Nov 9, 2022

Proposed changes

Release Notes

Types of changes

Checklist

codecov bot commented Nov 9, 2022 • edited Loading

Codecov Report

JillieBeanSim left a comment

Choose a reason for hiding this comment

JillieBeanSim Nov 28, 2022 • edited Loading

Choose a reason for hiding this comment

JillieBeanSim Nov 28, 2022

Choose a reason for hiding this comment

JillieBeanSim Nov 28, 2022

Choose a reason for hiding this comment

JillieBeanSim Nov 28, 2022 • edited Loading

Choose a reason for hiding this comment

JillieBeanSim Nov 28, 2022

Choose a reason for hiding this comment

JillieBeanSim Nov 28, 2022

Choose a reason for hiding this comment

KutluOzel-b commented Nov 29, 2022

JillieBeanSim left a comment • edited Loading

Choose a reason for hiding this comment

JillieBeanSim Dec 9, 2022

Choose a reason for hiding this comment

KutluOzel-b Dec 12, 2022

Choose a reason for hiding this comment

traeok commented Dec 12, 2022 • edited Loading

KutluOzel-b commented Dec 12, 2022

t1m0thyj left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 13, 2022

codecov bot commented Nov 9, 2022 •

edited

Loading

JillieBeanSim Nov 28, 2022 •

edited

Loading

JillieBeanSim Nov 28, 2022 •

edited

Loading

JillieBeanSim left a comment •

edited

Loading

traeok commented Dec 12, 2022 •

edited

Loading