-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change shortcut to available shortcut keybind #2545
Conversation
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, I don't see this combo in these charts of keybindings. Will add this link to our dev wiki for future reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rudyflores for the quick fix 🎉
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
…nsion-for-zowe into remove-history-shortcut
@JillieBeanSim @traeok sorry forgot the changelog (I noticed maintenance branch doesn't show a check for this though) |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Proposed changes
Fixes #2543
Changed the
Cmd/Ctrl + Y
keybind toCmd/Ctrl + Alt + Y
to avoid conflicts and place in a keybind that is availableRelease Notes
Milestone: v2.12.1
Changelog: Changed keybind for
Edit History
webview to non-conflicting shorcutTypes of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments