Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change shortcut to available shortcut keybind #2545

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

rudyflores
Copy link
Contributor

@rudyflores rudyflores commented Nov 6, 2023

Proposed changes

Fixes #2543

Changed the Cmd/Ctrl + Y keybind to Cmd/Ctrl + Alt + Y to avoid conflicts and place in a keybind that is available

Release Notes

Milestone: v2.12.1

Changelog: Changed keybind for Edit History webview to non-conflicting shorcut

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
@rudyflores rudyflores self-assigned this Nov 6, 2023
@rudyflores rudyflores added this to the v2.12.1 milestone Nov 6, 2023
@rudyflores rudyflores linked an issue Nov 6, 2023 that may be closed by this pull request
JillieBeanSim
JillieBeanSim previously approved these changes Nov 6, 2023
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I don't see this combo in these charts of keybindings. Will add this link to our dev wiki for future reference

Base automatically changed from merging/main-2.12.0 to maintenance November 6, 2023 16:48
@JillieBeanSim JillieBeanSim dismissed their stale review November 6, 2023 16:48

The base branch was changed.

@JillieBeanSim JillieBeanSim self-requested a review November 6, 2023 16:49
JillieBeanSim
JillieBeanSim previously approved these changes Nov 6, 2023
traeok
traeok previously approved these changes Nov 6, 2023
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rudyflores for the quick fix 🎉

Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
@rudyflores rudyflores dismissed stale reviews from traeok and JillieBeanSim via 5f34760 November 6, 2023 17:00
@rudyflores
Copy link
Contributor Author

@JillieBeanSim @traeok sorry forgot the changelog (I noticed maintenance branch doesn't show a check for this though)

Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@JillieBeanSim JillieBeanSim merged commit 910f86d into maintenance Nov 6, 2023
21 checks passed
@JillieBeanSim JillieBeanSim deleted the remove-history-shortcut branch November 6, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTRL + Y no longer works as expected in VS Code
3 participants