-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for hiding profile from all trees #2566
Conversation
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
==========================================
+ Coverage 92.75% 92.80% +0.04%
==========================================
Files 104 104
Lines 10315 10371 +56
Branches 2192 2201 +9
==========================================
+ Hits 9568 9625 +57
+ Misses 746 745 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Fernando! That issue should be resolved once this PR is merged #2559 As for the menu order issue you mentioned that is not relevant to this change, but could create an issue for that an I can address that separately :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - left a comment about a type cast, but the current logic won't affect the behavior 😅
Thanks @rudyflores!
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
I'll wait for the PR below before approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for removing the cast and fixing the errors from the type change 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rudyflores this is looking great! I do have one question.
If the profile name is only in a single tree, is there a way for us to know this and react appropriately? I tested this situation and had a profile name in a single tree and was still prompted to choose. I didn't get any errors or anything from choosing all trees, but wonder if we can tell beforehand, and if only in a single tree just remove it instead of the prompt that doesn't really make sense if only in one tree.
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Perhaps we can cycle through each tree and see if the session exists in atleast another tree, if only in the current tree we can just remove the current one? |
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was testing right before the meeting,
I just forgot to approve 😢
LGTM! 😋
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Proposed changes
Solves #2567
Add ability for the user to hide profiles in the tree in sync or individually based on their choice in the quickpick
Sample
Screen.Recording.2023-11-10.at.2.30.00.PM.mov
Release Notes
Milestone: 2.13.0
Changelog: Add support for hiding a Zowe profile across all trees
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments