Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update Zowe CLI to 7.23.6 to pull in Imperative bug fixes #2786

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Mar 14, 2024

Proposed changes

Resolves #2773
Updates the Zowe CLI dependency, resolving an issue that surfaced from Imperative's ProfileInfo class.

Release Notes

Milestone: 2.15.1

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (8cc44f4) to head (29c3f63).
Report is 5 commits behind head on maintenance.

❗ Current head 29c3f63 differs from pull request most recent head a21d708. Consider uploading reports for the commit a21d708 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           maintenance    #2786    +/-   ##
=============================================
  Coverage        93.27%   93.27%            
=============================================
  Files              102      102            
  Lines            10582    10582            
  Branches          2198     2300   +102     
=============================================
  Hits              9870     9870            
  Misses             711      711            
  Partials             1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@traeok
Copy link
Member Author

traeok commented Mar 14, 2024

Note that in the most recent commit (a21d708) I've removed Node 14 from the pipelines so that it supports the updated dependencies in Imperative.

Here's why I feel that it should be okay to remove Node 14 from the matrix:

  • The VS Code team recommends using at least Node 16 to build extensions for recent versions of VS Code - see here for more info
  • The latest version of VS Code uses Node 18
  • The oldest version of VS Code that we claim to support (1.53.2) uses Node 12, but I was able to build the extension using Node 16 (or even Node 18) and used it without issue
  • VS Code 1.56 and above use at least Node 14

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
just waiting on others to review before merging 🥳

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @traeok thanks this looks good to me, are we planning a patch release with this update and has it already been updated on main? I ask since we were just publishing from maintenance and developing against main & next.

@traeok
Copy link
Member Author

traeok commented Mar 18, 2024

Hey @traeok thanks this looks good to me, are we planning a patch release with this update and has it already been updated on main? I ask since we were just publishing from maintenance and developing against main & next.

@JillieBeanSim I was hoping that we could get a patch release in with this fix as well as the "quick pick separators" check in #2771 if that's okay 😅

It has not already been updated on main, but I can address that if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants