-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update Zowe CLI to 7.23.6 to pull in Imperative bug fixes #2786
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maintenance #2786 +/- ##
=============================================
Coverage 93.27% 93.27%
=============================================
Files 102 102
Lines 10582 10582
Branches 2198 2300 +102
=============================================
Hits 9870 9870
Misses 711 711
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Quality Gate passedIssues Measures |
Note that in the most recent commit (a21d708) I've removed Node 14 from the pipelines so that it supports the updated dependencies in Imperative. Here's why I feel that it should be okay to remove Node 14 from the matrix:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
just waiting on others to review before merging 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @traeok thanks this looks good to me, are we planning a patch release with this update and has it already been updated on main? I ask since we were just publishing from maintenance and developing against main & next.
@JillieBeanSim I was hoping that we could get a patch release in with this fix as well as the "quick pick separators" check in #2771 if that's okay 😅 It has not already been updated on main, but I can address that if needed |
Proposed changes
Resolves #2773
Updates the Zowe CLI dependency, resolving an issue that surfaced from Imperative's
ProfileInfo
class.Release Notes
Milestone: 2.15.1
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executed