Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProfilesCache): Clear object caches before refresh #2795

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Mar 20, 2024

Proposed changes

Resolves #2395

Release Notes

Milestone: 2.15.2

Changelog:

  • Fixed an issue where the ProfilesCache class would retain old service profiles, even if they were removed from the team config.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found

traeok added 2 commits March 20, 2024 14:50
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok changed the title fix(ProfilesCache): Clear profilesByType array before refresh fix(ProfilesCache): Clear profilesByType object before refresh Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (143f5d1) to head (6346758).

Additional details and impacted files
@@             Coverage Diff              @@
##           maintenance    #2795   +/-   ##
============================================
  Coverage        93.29%   93.29%           
============================================
  Files              103      103           
  Lines            10653    10655    +2     
  Branches          2232     2316   +84     
============================================
+ Hits              9939     9941    +2     
  Misses             713      713           
  Partials             1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…resh

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
zFernand0
zFernand0 previously approved these changes Mar 21, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue isn't a high priority one, but given the size of the fix, I don't mind if this PR is combined with #2760

Changes LGTM! 😋

Please don't forget to open a PR from maintenance to main once the 2.15.2 is out.

I don't believe I've seen one for the 2.15.1 patch yet 😋

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok requested review from t1m0thyj and zFernand0 March 25, 2024 14:33
@traeok traeok changed the title fix(ProfilesCache): Clear profilesByType object before refresh fix(ProfilesCache): Clear object caches before refresh Mar 25, 2024
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@traeok traeok marked this pull request as draft March 25, 2024 18:15
@JillieBeanSim JillieBeanSim added this to the v2.15.2 milestone Mar 27, 2024
@traeok traeok marked this pull request as ready for review April 2, 2024 18:20
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@traeok traeok merged commit e7b703f into maintenance Apr 2, 2024
19 checks passed
@traeok traeok deleted the fix/profcache/prof-by-type branch April 2, 2024 19:18
Copy link

github-actions bot commented Apr 2, 2024

Release succeeded for the maintenance branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants