-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ProfilesCache): Clear object caches before refresh #2795
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
profilesByType
array before refreshprofilesByType
object before refresh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maintenance #2795 +/- ##
============================================
Coverage 93.29% 93.29%
============================================
Files 103 103
Lines 10653 10655 +2
Branches 2232 2316 +84
============================================
+ Hits 9939 9941 +2
Misses 713 713
Partials 1 1 ☔ View full report in Codecov by Sentry. |
…resh Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue isn't a high priority one, but given the size of the fix, I don't mind if this PR is combined with #2760
Changes LGTM! 😋
Please don't forget to open a PR from maintenance
to main
once the 2.15.2 is out.
I don't believe I've seen one for the 2.15.1 patch yet 😋
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
profilesByType
object before refreshSigned-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Quality Gate passedIssues Measures |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
Proposed changes
Resolves #2395
Release Notes
Milestone: 2.15.2
Changelog:
ProfilesCache
class would retain old service profiles, even if they were removed from the team config.Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executed