Fix undefined node error on save #2801
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
t1m0thyj
requested review from
zFernand0,
JillieBeanSim,
awharn,
rudyflores and
traeok
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maintenance #2801 +/- ##
===============================================
+ Coverage 88.20% 93.29% +5.09%
===============================================
Files 103 103
Lines 10679 10653 -26
Branches 2223 2320 +97
===============================================
+ Hits 9419 9939 +520
+ Misses 1259 713 -546
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
t1m0thyj
changed the title
| ?.children.find((child) => child.label.toString().trim() === dataSetName) | ||
| ?.children.find((child) => child.label.toString().trim() === memberName) as api.IZoweDatasetTreeNode | ||
| )?.getEtag(); | ||
| // TODO Handle case where same data set is open as both favorite and non-favorite to prevent desync between equivalent nodes |
There was a problem hiding this comment.
Having the same data set open both as a favorite and non-favorite is probably enough of an edge case that we can wait to address it in v3. Discussed with @traeok and we believe the FileSystemProvider should fix the desync since it stores data per URI rather than per node 😋
| @@ -117,21 +117,6 @@ export async function refreshDirectory(node: IZoweUSSTreeNode, ussFileProvider: | |||
| } | |||
| } | |||
|
|
|||
| export async function createUSSNodeDialog(node: IZoweUSSTreeNode, ussFileProvider: IZoweTree<IZoweUSSTreeNode>): Promise<void> { | |||
There was a problem hiding this comment.
Removed this because it's dead code that's not called anywhere and it's not a public API
Proposed changes
This PR addresses several issues that can cause the undefined node error:
onDidCloseTextDocumentis misleadingly named - it fires whenever a document's language is changed.createMemberaction so that member name is converted to uppercase. Also the new member's etag is now stored in a child node of the tree instead of an orphan node.Release Notes
Milestone: 2.15.2
Changelog: Fixed issue where saving changes to favorited data set or USS file could fail
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments