-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): Log schema warnings instead of UI warning message #2860
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maintenance #2860 +/- ##
===============================================
- Coverage 93.44% 93.43% -0.01%
===============================================
Files 103 103
Lines 10675 10675
Branches 2324 2324
===============================================
- Hits 9975 9974 -1
- Misses 699 700 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I was able to get the warning to appear by downgrading to the 2.0.0 version of the FTP extension. With a build of this PR, the warning appears in the log but not as a pop-up. 👍
Quality Gate passedIssues Measures |
Proposed changes
Since developers and extenders are the primary users to inform when schema warnings occur, I figured it was best to move this into the log file for now until an "error code" is added to the schema management return values. Once that is available we can choose to show UI messages for specific scenarios - currently, I would have to implement hardcoded checks against error messages and I don't think that is a viable solution.
Release Notes
Milestone:
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executed