Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Log schema warnings instead of UI warning message #2860

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Apr 18, 2024

Proposed changes

Since developers and extenders are the primary users to inform when schema warnings occur, I figured it was best to move this into the log file for now until an "error code" is added to the schema management return values. Once that is available we can choose to show UI messages for specific scenarios - currently, I would have to implement hardcoded checks against error messages and I don't think that is a viable solution.

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.43%. Comparing base (93270d0) to head (4c30ca8).
Report is 1 commits behind head on maintenance.

Additional details and impacted files
@@               Coverage Diff               @@
##           maintenance    #2860      +/-   ##
===============================================
- Coverage        93.44%   93.43%   -0.01%     
===============================================
  Files              103      103              
  Lines            10675    10675              
  Branches          2324     2324              
===============================================
- Hits              9975     9974       -1     
- Misses             699      700       +1     
  Partials             1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I was able to get the warning to appear by downgrading to the 2.0.0 version of the FTP extension. With a build of this PR, the warning appears in the log but not as a pop-up. 👍

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@traeok traeok merged commit 9a9f210 into maintenance Apr 18, 2024
25 checks passed
@traeok traeok deleted the fix/log-schema-warnings branch April 18, 2024 18:10
@JillieBeanSim JillieBeanSim added this to the v2.15.3 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants