fix(v3): Fix sessions disappearing from trees caused by zowe.extRefresh

[t1m0thyj]

Proposed changes

Fixes #2906

Release Notes

Milestone: v3

Changelog: Fixed issue where creating new team configuration file could cause Zowe Explorer to crash, resulting in all sessions disappearing from trees

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.82%. Comparing base (3ba345a) to head (685aa30).

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #3009      +/-   ##
==========================================
+ Coverage   92.74%   92.82%   +0.08%     
==========================================
  Files         107      107              
  Lines       10882    10887       +5     
  Branches     2360     2358       -2     
==========================================
+ Hits        10092    10106      +14     
+ Misses        788      779       -9     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[anaxceron]

One minor comment, but otherwise this looks dandy.

[traeok]

I was able to confirm that there was an issue with my Zowe team config's secure array. After resetting my config file and preparing my environment, I was unable to reproduce the previous scenario I encountered.

LGTM, thanks Timothy for the fix!

[zFernand0]

LGTM! 😋
I'm guessing it's ok for this port-PR to be merged before the V2 one since we don't need to verify Theia support for V3? 😋

[anaxceron]

Nice!

[sonarqubecloud]

Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[traeok]

I started reviewing this one first and ended up approving the v2 implementation by accident - oops 😅 Both PRs look good though.

LGTM, thanks Timothy!