Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support member wildcards in favorited searches #3067

Merged
merged 19 commits into from
Sep 9, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Aug 27, 2024

Proposed changes

  • Refactor pattern parsing and make modular
  • Update favorites logic to retain the full, user-entered pattern
  • Resolve issue with TypeError: Cannot read properties of undefined (reading 'direction') when expanding favorited children

This PR separates the pattern parsing logic from the dataset search prompt and moves it into the getDatasets and getChildren functions in ZoweDatasetNode. This allows us to leverage member wildcards within favorited searches. It also ensures that the user's pattern submission is respected even after changes are made to data sets on the mainframe.

Release Notes

Milestone: vNext

Changelog:

  • Implemented support for favoriting a data set search that contains member wildcards.
  • Resolved TypeError: Cannot read properties of undefined (reading 'direction') error for favorited items.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

traeok added 6 commits August 26, 2024 09:36
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
- Also resolves the TypeError with `direction` sort property for favorited children.

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok changed the base branch from main to next August 27, 2024 13:29
traeok added 2 commits August 27, 2024 09:30
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok linked an issue Aug 27, 2024 that may be closed by this pull request
traeok added 2 commits August 27, 2024 13:14
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.59%. Comparing base (7cc2b57) to head (1ccb317).
Report is 23 commits behind head on next.

Files with missing lines Patch % Lines
...zowe-explorer/src/trees/dataset/ZoweDatasetNode.ts 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3067      +/-   ##
==========================================
- Coverage   92.77%   92.59%   -0.18%     
==========================================
  Files         113      113              
  Lines       11608    11602       -6     
  Branches     2538     2566      +28     
==========================================
- Hits        10769    10743      -26     
- Misses        837      857      +20     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

traeok added 4 commits August 27, 2024 13:31
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok marked this pull request as ready for review August 27, 2024 18:14
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@adam-wolfe

This comment was marked as resolved.

… favorite

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok
Copy link
Member Author

traeok commented Aug 27, 2024

Thanks for reporting this @adam-wolfe, the latest commit resolves this issue.

I am a bit concerned that recent changes to getSessionNode have altered the behavior of pre-existing ZE features. I feel we should investigate our tree view functionalities to verify that they are still working as expected.

I've created an issue to track this potential bug: #3073

@adam-wolfe adam-wolfe added this to the v3.1.0 milestone Sep 3, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Curious if some of the datasetTree private functions could be exported for ZE extenders to use in the future? 😋

Copy link

sonarqubecloud bot commented Sep 9, 2024

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great! thanks @traeok for this addition

@JillieBeanSim JillieBeanSim merged commit 67e8a2d into next Sep 9, 2024
29 checks passed
@JillieBeanSim JillieBeanSim deleted the feat/favorites-member-wildcard branch September 9, 2024 18:17
@JillieBeanSim JillieBeanSim modified the milestones: v3.1.0, v3.0.0 GA Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Filtered data sets can't be added to favorites
4 participants