-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support member wildcards in favorited searches #3067
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
- Also resolves the TypeError with `direction` sort property for favorited children. Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3067 +/- ##
==========================================
- Coverage 92.77% 92.59% -0.18%
==========================================
Files 113 113
Lines 11608 11602 -6
Branches 2538 2566 +28
==========================================
- Hits 10769 10743 -26
- Misses 837 857 +20
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
This comment was marked as resolved.
This comment was marked as resolved.
… favorite Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Thanks for reporting this @adam-wolfe, the latest commit resolves this issue. I am a bit concerned that recent changes to I've created an issue to track this potential bug: #3073 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Curious if some of the datasetTree private functions could be exported for ZE extenders to use in the future? 😋
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great! thanks @traeok for this addition
Proposed changes
TypeError: Cannot read properties of undefined (reading 'direction')
when expanding favorited childrenThis PR separates the pattern parsing logic from the dataset search prompt and moves it into the
getDatasets
andgetChildren
functions inZoweDatasetNode
. This allows us to leverage member wildcards within favorited searches. It also ensures that the user's pattern submission is respected even after changes are made to data sets on the mainframe.Release Notes
Milestone: vNext
Changelog:
TypeError: Cannot read properties of undefined (reading 'direction')
error for favorited items.Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment