-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Automated merge-by comments and table #3090
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
📅 Suggested merge-by date: 9/18/2024 |
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
3c4ec2f
to
2c52732
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Quality Gate passedIssues Measures |
Hey @traeok this is looking really cool. One question, why is the |
Thanks Billie! This is because the token used for that action needs to have its permissions updated so it has write permission for pull requests. I was going to update it myself, but unfortunately the token permissions are restricted to a few users in the org and I do not have the necessary access to change them. |
I was looking into this from the CLI perspective, but decided to move the investigation/test to a fork: More details, the token used for this specific action is the Zowe-Robot-token, which was created using the classic token method instead of fine-grained PATs. With classic tokens, the level of permission might be a bit too broad so we may be forced to create more fine-grained PATs going forward 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem like to learned a lot of graphQL 😋
LGTM! 🥳
If it's not working why did it get approved and merged? @traeok @zFernand0 @awharn |
I can't speak for why it was merged, but that check is failing across the entire org right now because someone changed Zowe's default permissions for the GITHUB_TOKEN to be read only in the workflows. We are in the process of opening pull requests in all of our repos to update all the workflows. It should be unrelated to the changes made here. That workflow is what updates the PRs and Issues on the project board on our standups. @JillieBeanSim |
The |
I understand the possibility of glitches/failures on existing workflows but it's not good practice to introduce new items (code, workflows, etc.) into the code base if not working during the time of introduction. |
@traeok please port these changes to the |
Hey @JillieBeanSim, I'm more than happy to provide more details on a quick call if needed. 😋 |
Proposed changes
Adds two new workflows to the
.github
folder of the repo:merge-by-comments.yml
merge-by-table.yml
Types of changes
Checklist
General