Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To fix Strange behaviour of Job label under Job Favorites #3144

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

SanthoshiBoyina1
Copy link
Contributor

Proposed changes

Solves #2632
To fix the incorrect job label under favorites when VSC is reloaded

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Copy link

📅 Suggested merge-by date: 10/8/2024

Copy link
Contributor

@likhithanimma1 likhithanimma1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SanthoshiBoyina1 . Can you remove the unused import in the JobTree.unit.test.ts

Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
54.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (0d0e25a) to head (fa1fb30).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3144   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         113      113           
  Lines       11647    11649    +2     
  Branches     2481     2446   -35     
=======================================
+ Hits        10805    10807    +2     
  Misses        840      840           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SanthoshiBoyina1
Copy link
Contributor Author

Hey @SanthoshiBoyina1 . Can you remove the unused import in the JobTree.unit.test.ts

Fixed the issue

@likhithanimma1 likhithanimma1 self-requested a review September 24, 2024 07:48
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for porting the fix @SanthoshiBoyina1

@JillieBeanSim JillieBeanSim merged commit f3d5395 into main Sep 24, 2024
21 of 22 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/incorrectFavoriteJobLabel branch September 24, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants