-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To fix Strange behaviour of Job label under Job Favorites #3144
Conversation
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
📅 Suggested merge-by date: 10/8/2024 |
packages/zowe-explorer/__tests__/__unit__/trees/job/JobTree.unit.test.ts
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SanthoshiBoyina1 . Can you remove the unused import in the JobTree.unit.test.ts
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Quality Gate failedFailed conditions |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3144 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 113 113
Lines 11647 11649 +2
Branches 2481 2446 -35
=======================================
+ Hits 10805 10807 +2
Misses 840 840
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Fixed the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for porting the fix @SanthoshiBoyina1
Proposed changes
Solves #2632
To fix the incorrect job label under favorites when VSC is reloaded
Release Notes
Milestone:
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments