-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add context to PS nodes (support opening within favorited search) #3163
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3163 +/- ##
========================================
Coverage 92.79% 92.79%
========================================
Files 113 113
Lines 11669 11670 +1
Branches 2606 2502 -104
========================================
+ Hits 10828 10829 +1
Misses 839 839
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
📅 Suggested merge-by date: 10/15/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the quick fix @traeok!
7a826c0
to
90dcce4
Compare
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Quality Gate passedIssues Measures |
Proposed changes
There was a context value missing when we created new data set nodes, but we need to know the context when generating the resource URI. This adds the context value to new data set nodes through the
contextOverride
property, within the constructor options.Release Notes
Milestone: 3.0.1
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment