Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add context to PS nodes (support opening within favorited search) #3163

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Oct 1, 2024

Proposed changes

There was a context value missing when we created new data set nodes, but we need to know the context when generating the resource URI. This adds the context value to new data set nodes through the contextOverride property, within the constructor options.

Release Notes

Milestone: 3.0.1

Changelog:

  • Fixed an issue where opening sequential data sets within favorited searches resulted in an error.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (27836ed) to head (bc7680e).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3163    +/-   ##
========================================
  Coverage   92.79%   92.79%            
========================================
  Files         113      113            
  Lines       11669    11670     +1     
  Branches     2606     2502   -104     
========================================
+ Hits        10828    10829     +1     
  Misses        839      839            
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok changed the title fix(ZoweDatasetNode): Add contextOverride to PS node to allow opening within favorited search fix(ZoweDatasetNode): Add contextOverride to PS nodes (support opening within favorited search) Oct 1, 2024
@traeok traeok changed the title fix(ZoweDatasetNode): Add contextOverride to PS nodes (support opening within favorited search) fix(ZoweDatasetNode): Add context to PS nodes (support opening within favorited search) Oct 1, 2024
@traeok traeok marked this pull request as ready for review October 1, 2024 20:00
Copy link

github-actions bot commented Oct 1, 2024

📅 Suggested merge-by date: 10/15/2024

@traeok traeok changed the title fix(ZoweDatasetNode): Add context to PS nodes (support opening within favorited search) fix: Add context to PS nodes (support opening within favorited search) Oct 1, 2024
t1m0thyj
t1m0thyj previously approved these changes Oct 1, 2024
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix @traeok!

awharn
awharn previously approved these changes Oct 1, 2024
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
awharn
awharn previously approved these changes Oct 1, 2024
@t1m0thyj t1m0thyj added this to the v3.0.1 milestone Oct 2, 2024
@traeok traeok mentioned this pull request Oct 2, 2024
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

sonarqubecloud bot commented Oct 3, 2024

@JillieBeanSim JillieBeanSim merged commit 77235a3 into main Oct 3, 2024
21 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/fav-search/open-ps branch October 3, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants