fix: Move v1 conversion prompt into initialization

[traeok]

Proposed changes

Prompting the user to convert v1 profiles during readConfigFromDisk can cause the prompt to appear in scenarios where it shouldn't. One example is when making changes to a project config in one Zowe Explorer window, while another window is opened with Zowe Explorer & no team configs.

We should only prompt the user to convert their v1 profiles once during initialization. This PR moves the convert prompt logic into the ProfilesUtils.handleV1MigrationStatus function.

Release Notes

Milestone: 3.0.2

Changelog:

• Fixed an issue where Zowe Explorer sometimes prompted the user to convert v1 profiles when changes were made to a Team Config after initialization. #3246

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

[github-actions]

📅 Suggested merge-by date: 10/30/2024

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (ef47e27) to head (0cf50ba).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3246      +/-   ##
==========================================
- Coverage   93.02%   93.02%   -0.01%     
==========================================
  Files         113      113              
  Lines       11711    11706       -5     
  Branches     2638     2521     -117     
==========================================
- Hits        10894    10889       -5     
  Misses        815      815              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JillieBeanSim]

LGTM! thanks for fix @traeok

[anaxceron]

Suggesting minor edits to the changelog. Thank you @traeok

[t1m0thyj]

Seeing an issue when testing migration in a VM, not sure if this behavior is expected:

• Have environment with V1 profiles
• Install Zowe Explorer V1 and verify that profile shows in trees
• Install Zowe Explorer V3 (built from this branch)
• In VS Code notification, select "Restart Extensions"
• In ZE modal dialog, select "Create New"
• Notice that new config is created but DS and Jobs trees failed to load

[t1m0thyj]

LGTM, thanks @traeok! Just needed to reset VS Code in my VM since it had settings left over from a previous V3 migration test 😋