-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redo reprompt Cred #580
redo reprompt Cred #580
Conversation
Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 37 37
Lines 3420 3420
Branches 609 609
=======================================
Hits 3121 3121
Misses 296 296
Partials 3 3 Continue to review full report at Codecov.
|
Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
Note: There are issues found connected to SCS and I opened a separate issue (#586) for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got an error with uss.
rejected promise not handled within 1 second: Error: Could not find profile named: 3bPromptMe [/u/stonecc]. extensionHostProcess.js:839 stack trace: Error: Could not find profile named: 3bPromptMe [/u/stonecc]. at Profiles.loadNamedProfile (/Users/colin.stone@uk.ibm.com/git/vscode-extension-for-zowe/out/src/Profiles.js:57:15)
The label used contains the filter I was attempting to access
Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jelly. Nice tidy piece of function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Found another error with optional credentials, but none with your function 🥇
@katelynienaber Can you open an issue please so I can track it? thank you. |
Ya here it is: #621 Also linked it there to #373 |
@jellypuno Looks good, except few minor moments in tests. |
Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
@jellypuno Looks good, thanks! |
Signed-off-by: jellypuno jessielaine.punongbayan@broadcom.com