Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo reprompt Cred #580

Merged
merged 11 commits into from
Mar 16, 2020
Merged

redo reprompt Cred #580

merged 11 commits into from
Mar 16, 2020

Conversation

jellypuno
Copy link
Contributor

Signed-off-by: jellypuno jessielaine.punongbayan@broadcom.com

Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #580 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files          37       37           
  Lines        3420     3420           
  Branches      609      609           
=======================================
  Hits         3121     3121           
  Misses        296      296           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62dd30a...bd36d22. Read the comment docs.

Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
@jellypuno
Copy link
Contributor Author

Note: There are issues found connected to SCS and I opened a separate issue (#586) for that

Copy link
Member

@Colin-Stone Colin-Stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got an error with uss.
rejected promise not handled within 1 second: Error: Could not find profile named: 3bPromptMe [/u/stonecc]. extensionHostProcess.js:839 stack trace: Error: Could not find profile named: 3bPromptMe [/u/stonecc]. at Profiles.loadNamedProfile (/Users/colin.stone@uk.ibm.com/git/vscode-extension-for-zowe/out/src/Profiles.js:57:15)

The label used contains the filter I was attempting to access

Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
@zFernand0 zFernand0 linked an issue Mar 5, 2020 that may be closed by this pull request
@jellypuno jellypuno linked an issue Mar 6, 2020 that may be closed by this pull request
Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
@jellypuno jellypuno requested a review from Colin-Stone March 6, 2020 15:11
@jellypuno jellypuno added this to the 1.4 Release milestone Mar 9, 2020
@Colin-Stone Colin-Stone dismissed their stale review March 10, 2020 09:18

Thanks Jelly that's all working now

Copy link
Member

@Colin-Stone Colin-Stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jelly. Nice tidy piece of function

Copy link
Contributor

@katelynienaber katelynienaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Found another error with optional credentials, but none with your function 🥇

@jellypuno jellypuno removed the request for review from crawr March 12, 2020 21:53
@jellypuno
Copy link
Contributor Author

@katelynienaber Can you open an issue please so I can track it? thank you.

@katelynienaber
Copy link
Contributor

@katelynienaber Can you open an issue please so I can track it? thank you.

Ya here it is: #621

Also linked it there to #373

@stepanzharychevbroadcom
Copy link
Contributor

@jellypuno Looks good, except few minor moments in tests.

Signed-off-by: jellypuno <jessielaine.punongbayan@broadcom.com>
@stepanzharychevbroadcom
Copy link
Contributor

@jellypuno Looks good, thanks!

@jellypuno jellypuno merged commit e0bf66a into master Mar 16, 2020
@jellypuno jellypuno deleted the Issue-370 branch March 16, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error encountered in datasetFilterPrompt.optionalProfiles! Re-Prompting of Credentials
4 participants