Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize context menus #834

Merged
merged 8 commits into from
Jun 10, 2020
Merged

Reorganize context menus #834

merged 8 commits into from
Jun 10, 2020

Conversation

katelynienaber
Copy link
Contributor

@katelynienaber katelynienaber commented Jun 4, 2020

Signed-off-by: Katelyn Nienaber katelyn.nienaber@broadcom.com

Proposed changes

Rearranged context menus & toolbar commands according to issues #347 and #765

Release Notes

Milestone: Backlog

Changelog: Rearranged context menus & toolbar commands

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • npm run vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
@katelynienaber katelynienaber added this to the Backlog milestone Jun 4, 2020
@katelynienaber katelynienaber self-assigned this Jun 4, 2020
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #834 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #834   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files          47       47           
  Lines        4331     4331           
  Branches      765      765           
=======================================
  Hits         3902     3902           
  Misses        425      425           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ca792...50d4dbe. Read the comment docs.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Pranay154 Pranay154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katelynienaber Thanks for doing this! Looks great 👍 Just the one comment I've left.

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
@lauren-li
Copy link
Contributor

lauren-li commented Jun 4, 2020

@katelynienaber Thank you for your work on this!

For Data Sets, could we keep the "Delete" group of commands at the bottom, as that's how VS Code does their context menus? "Migrate" and "Recall" are currently numbered to show up below "Delete" and its related commands.

katelynienaber and others added 3 commits June 5, 2020 11:17
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Copy link
Contributor

@Pranay154 Pranay154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im happy with the changes, thanks for doing this 😄

@katelynienaber
Copy link
Contributor Author

@katelynienaber Thank you for your work on this!

For Data Sets, could we keep the "Delete" group of commands at the bottom, as that's how VS Code does their context menus? "Migrate" and "Recall" are currently numbered to show up below "Delete" and its related commands.

This should be done now :) Was just waiting for Jenkins to cooperate...

Copy link
Contributor

@lauren-li lauren-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katelynienaber for considering my suggestion! This looks good to me now. All unit and system tests are passing, and functional testing seems to work well without any regressions. I appreciate that the context menu organization feels closer to VS Code's file explorer context menus with this PR.

Copy link
Contributor

@VitGottwald VitGottwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only comment I have is that we should let people know we changed stuff. Pictures would be best. I wonder if we have a way to deliver such an update.

@zFernand0 zFernand0 merged commit 3b10640 into master Jun 10, 2020
@zFernand0 zFernand0 deleted the reorganize-context-menus branch June 10, 2020 18:10
@zFernand0 zFernand0 modified the milestones: Backlog, 1.7 Release Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move link profile to context menu next to hide/delete profile Reorganize Data Sets context menu
5 participants