-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize context menus #834
Conversation
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 47 47
Lines 4331 4331
Branches 765 765
=======================================
Hits 3902 3902
Misses 425 425
Partials 4 4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katelynienaber Thanks for doing this! Looks great 👍 Just the one comment I've left.
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
@katelynienaber Thank you for your work on this! For Data Sets, could we keep the "Delete" group of commands at the bottom, as that's how VS Code does their context menus? "Migrate" and "Recall" are currently numbered to show up below "Delete" and its related commands. |
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im happy with the changes, thanks for doing this 😄
This should be done now :) Was just waiting for Jenkins to cooperate... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @katelynienaber for considering my suggestion! This looks good to me now. All unit and system tests are passing, and functional testing seems to work well without any regressions. I appreciate that the context menu organization feels closer to VS Code's file explorer context menus with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The only comment I have is that we should let people know we changed stuff. Pictures would be best. I wonder if we have a way to deliver such an update.
Signed-off-by: Katelyn Nienaber katelyn.nienaber@broadcom.com
Proposed changes
Rearranged context menus & toolbar commands according to issues #347 and #765
Release Notes
Milestone: Backlog
Changelog: Rearranged context menus & toolbar commands
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewernpm run vscode:prepublish
has been executed