-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Zowe CLI version #835
Conversation
Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
+ Coverage 90.07% 90.09% +0.02%
==========================================
Files 47 47
Lines 4342 4331 -11
Branches 766 765 -1
==========================================
- Hits 3911 3902 -9
+ Misses 427 425 -2
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems to be working good
- MVS (view, upload, migrate, recall, run jcl, delete, save, rename)
- JOBS (view, download, delete)
- USS (view, upload, save, rename)
All tests and checks are passing. Thanks @lauren-li for updating the CLI version!
I did run across some things while testing that are possible issues/enhancements that are in master branch as well
- JOB must have arrow clicked to expand and collapse where MVS & USS clicking the name for ds or dir will do.
- Delete JOB doesn't automatically refresh tree like MVS & USS delete does, have to manually refresh.
- I wonder if data set tree should automatically refresh after Migrate/Recall is clicked to update the icons? This action has to be manually done as well.
I have encountered some of these in the current version of Zowe Explorer, as well, and I agree they would be good to file as separate issues. Thanks @JillieBeanSim for testing out the Zowe CLI version update so thoroughly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! 😋
I agree with having separate issues for these items.
In case you are interested, see related issues below:
maybe #830
maybe #578
maybe #844 |
Proposed changes
This pull request updates the Zowe CLI version from 6.13.0 to 6.14.0. Version 6.14.0 uses Zowe Imperative version 4.6.4, which includes logging with improved compatibility with Webpack (needed for issue #74).
(More generally, Zowe CLI 6.14.0 also adds encoding/code page support for data set upload and download operations in library and CLI.)
Release Notes
Milestone: 1.7 Release
Changelog: Update Zowe CLI to version 6.14.0.
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewernpm run vscode:prepublish
has been executedI have added unit test and it is passing(N/A; all existing unit tests passing)I have added integration test and it is passing(N/A; all existing integration tests passing)I have added necessary documentation (if appropriate)(N/A)Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...