Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zowe CLI version #835

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Update Zowe CLI version #835

merged 1 commit into from
Jun 9, 2020

Conversation

lauren-li
Copy link
Contributor

@lauren-li lauren-li commented Jun 4, 2020

Proposed changes

This pull request updates the Zowe CLI version from 6.13.0 to 6.14.0. Version 6.14.0 uses Zowe Imperative version 4.6.4, which includes logging with improved compatibility with Webpack (needed for issue #74).

(More generally, Zowe CLI 6.14.0 also adds encoding/code page support for data set upload and download operations in library and CLI.)

Release Notes

Milestone: 1.7 Release

Changelog: Update Zowe CLI to version 6.14.0.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • npm run vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing (N/A; all existing unit tests passing)
  • I have added integration test and it is passing (N/A; all existing integration tests passing)
  • ~~There is coverage for the code that I have added`~ (N/S)
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate) (N/A)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
@lauren-li lauren-li requested a review from zFernand0 June 4, 2020 17:37
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #835 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   90.07%   90.09%   +0.02%     
==========================================
  Files          47       47              
  Lines        4342     4331      -11     
  Branches      766      765       -1     
==========================================
- Hits         3911     3902       -9     
+ Misses        427      425       -2     
  Partials        4        4              
Impacted Files Coverage Δ
src/uss/ZoweUSSNode.ts 84.70% <0.00%> (-0.06%) ⬇️
src/dataset/ZoweDatasetNode.ts 100.00% <0.00%> (ø)
src/Profiles.ts 95.06% <0.00%> (+0.12%) ⬆️
src/job/ZoweJobNode.ts 93.38% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8fccd...1a85e30. Read the comment docs.

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to be working good

  • MVS (view, upload, migrate, recall, run jcl, delete, save, rename)
  • JOBS (view, download, delete)
  • USS (view, upload, save, rename)

All tests and checks are passing. Thanks @lauren-li for updating the CLI version!

I did run across some things while testing that are possible issues/enhancements that are in master branch as well

  • JOB must have arrow clicked to expand and collapse where MVS & USS clicking the name for ds or dir will do.
  • Delete JOB doesn't automatically refresh tree like MVS & USS delete does, have to manually refresh.
  • I wonder if data set tree should automatically refresh after Migrate/Recall is clicked to update the icons? This action has to be manually done as well.

@lauren-li
Copy link
Contributor Author

I did run across some things while testing that are possible issues/enhancements that are in master branch as well

  • JOB must have arrow clicked to expand and collapse where MVS & USS clicking the name for ds or dir will do.

  • Delete JOB doesn't automatically refresh tree like MVS & USS delete does, have to manually refresh.

  • I wonder if data set tree should automatically refresh after Migrate/Recall is clicked to update the icons? This action has to be manually done as well.

I have encountered some of these in the current version of Zowe Explorer, as well, and I agree they would be good to file as separate issues.

Thanks @JillieBeanSim for testing out the Zowe CLI version update so thoroughly!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! 😋
I agree with having separate issues for these items.

@zFernand0 zFernand0 merged commit 03ca792 into master Jun 9, 2020
@zFernand0 zFernand0 deleted the update-zowe-cli branch June 9, 2020 15:26
@zFernand0
Copy link
Member

In case you are interested, see related issues below:

  • JOB must have arrow clicked to expand and collapse where MVS & USS clicking the name for ds or dir will do.

maybe #830

  • Delete JOB doesn't automatically refresh tree like MVS & USS delete does, have to manually refresh.

maybe #578

  • I wonder if data set tree should automatically refresh after Migrate/Recall is clicked to update the icons? This action has to be manually done as well.

maybe #844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants