PR: Add full identity handling to the frontend #32 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchojnacki
changed the title
…o 32-add-full-identity-handling-to-the-frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for reviewers:
The diff has definitely too many files, since I moved one folder 😠
The files, that were actually meaningfully changed:
/common/identity/*.ts- entire new folder, main thing to review/tests/common/identity.test.tsx- tests for new functionality/app/auth/(login|register).tsx- communication with backend, redirects, error handling/app/dashboard.tsx- stub file for dashboard/app/profiles/list.tsx- stub file for profile selection, to be merged with Account profile selection #34/common/util/mock-router.tsx- self-explainatoryAll of the other changes are just renames, import fixes, etc.
Notes for all contributors:
Familiarize yourself with the functions exported from
@/common/identity, example usage is show on theloginandregisterpages.