PR: Setup boilerplate for the home screen #14 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchojnacki
commented
Oct 18, 2023
| import { View } from "@/components/Themed"; | ||
|
|
||
| const mockDashboardGadgets: ActionKey[] = [ |
There was a problem hiding this comment.
Placeholder - this will be downloaded from the backend.
| @@ -34,7 +37,7 @@ export const Landing = ({ debug = false }: { debug?: boolean }) => { | |||
| {debug ? ( | |||
| <> | |||
| <MonoText style={styles.debug}> | |||
| {new URL("/healthz", BASE_URL).toString()} | |||
There was a problem hiding this comment.
This was broken after the API change 😨
| @@ -0,0 +1,16 @@ | |||
| import type { Action } from "./types"; | |||
|
|
|||
| export const actions = { | |||
| @@ -20,3 +20,13 @@ export const MockRouter = ({ | |||
| location={new URL(initialRoute, "test://")} | |||
| /> | |||
| ); | |||
|
|
|||
| export const clearHistory = ( | |||
| ); | ||
| const logOut = useCallback(() => setData({ known: "nothing" }), [setData]); | ||
| const logOut = useCallback(() => { | ||
| clearHistory(router, "/auth/login"); |
There was a problem hiding this comment.
There were many weird edge cases, e.g.:
- Log in
- Select profile
- Go from dashboard to menu
- Log out
- You now have the "back" button (going to the dashboard) visible - it doesn't do anything because of safety mechanisms from my last PR, but it is there nevertheless
We reset the router on every identity change to ensure that doesn't happen.
tchojnacki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously the specific buttons located on the dashboard and the menu are just placeholders, but we have the page "skeleton" set up.
Dashboard:
Menu (senior):
Menu (caretaker):
