Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Implement the new profile creation screen #37

Merged
merged 5 commits into from
Oct 22, 2023
Merged

PR: Implement the new profile creation screen #37

merged 5 commits into from
Oct 22, 2023

Conversation

kubaczerwinski77
Copy link
Contributor

@kubaczerwinski77 kubaczerwinski77 commented Oct 18, 2023 •
edited
Loading

About:

  • new button in profile selection screen
  • screen for senior profile creation with QR code placeholder
  • screen for caretaker profile with QR scanner and empty handlers

@kubaczerwinski77 kubaczerwinski77 changed the title DRAFT: Implement the new profile creation screen PR: Implement the new profile creation screen Oct 22, 2023
tchojnacki
tchojnacki approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@tchojnacki tchojnacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues, there are some missing translations, which we should include since we now have a language change button (and it would be weird to have a page use mixed languages).

Approving in blanco, but I hope you will add them before merging.

app/profile/caretaker/add.tsx Outdated Show resolved Hide resolved
app/profile/caretaker/scanQR.tsx Outdated Show resolved Hide resolved
app/profile/caretaker/scanQR.tsx Outdated Show resolved Hide resolved
app/profile/list.tsx Outdated Show resolved Hide resolved
common/util/constants.ts Outdated Show resolved Hide resolved
@tchojnacki tchojnacki linked an issue Oct 22, 2023 that may be closed by this pull request
Implement the new profile creation screen #24
Closed
tchojnacki
tchojnacki approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@tchojnacki tchojnacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@kubaczerwinski77 kubaczerwinski77 merged commit 42d474f into main Oct 22, 2023
1 check passed
@kubaczerwinski77 kubaczerwinski77 deleted the 24-implement-the-new-profile-selection-screen branch October 22, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchojnacki tchojnacki tchojnacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the new profile creation screen
2 participants
@kubaczerwinski77 @tchojnacki