Add issued_at_leeway as a config parameter
#231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When receiving the JSON Web Token response back from Google, it includes an Issued At timestamp in unix time. If your clock is behind this timestamp, you will receive `JWT::InvalidIatError` since by default, it does not allow future tokens.
Adding leeway as a configurable option makes it easy to allow for future tokens with whatever tolerance you are comfortable with in the `config.omniauth` statement.
Usage:
config.omniauth :google_oauth2, ENV['GOOGLE_OAUTH_ID'], ENV['GOOGLE_OAUTH_SECRET'], {
scope: "email", access_type: "offline", issued_at_leeway: 300
}
|
This was already added. #230 |
|
Really appreciate you giving it a go, but with jwt 1.5.x there were side effects, like ruby 1.9 not working anymore. You can see the other adjustments in my PR. |
|
Cool, thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving the JSON Web Token response back from Google, it includes an Issued At timestamp in unix time. If your clock is behind this timestamp, you will receive
JWT::InvalidIatErrorsince by default, it does not allow future tokens.Adding leeway as a configurable option makes it easy to allow for future tokens with whatever tolerance you are comfortable with in the
config.omniauthstatement.Example Usage:
This is in response to #195