Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new ZIA Cloud App Control Rule and URL Domain Review Endpoints #270

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Jul 22, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@willguibr willguibr self-assigned this Jul 22, 2024
@willguibr willguibr added documentation Improvements or additions to documentation enhancement New feature or request ZIA New API Resources ZIA New API Resources new-acceptance-tests New acceptance tests zia-new-attributes ZIA API Added New Parameters labels Jul 22, 2024
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_THREE July 22, 2024 19:46 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 44.52055% with 81 lines in your changes missing coverage. Please review.

Project coverage is 57.63%. Comparing base (a796d8f) to head (b581c0d).

Files Patch % Lines
zia/client.go 0.00% 32 Missing ⚠️
zia/services/urlcategories/urlcategories.go 35.71% 23 Missing and 4 partials ⚠️
zia/services/cloudappcontrol/cloudappcontrol.go 67.74% 16 Missing and 4 partials ⚠️
...ia/services/dlp/dlpdictionaries/dlpdictionaries.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   58.17%   57.63%   -0.54%     
==========================================
  Files         173      152      -21     
  Lines        6537     6107     -430     
==========================================
- Hits         3803     3520     -283     
+ Misses       2203     2106      -97     
+ Partials      531      481      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request new-acceptance-tests New acceptance tests ZIA New API Resources ZIA New API Resources zia-new-attributes ZIA API Added New Parameters
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

1 participant