Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed ZPA/ZIA pagination and ZPA Complex Rule template. #200

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Nov 5, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@willguibr willguibr self-assigned this Nov 5, 2024
@willguibr willguibr added the bug Something isn't working label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.92%. Comparing base (668f1e5) to head (1dda4d8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
zscaler/zpa/policies.py 50.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   71.00%   70.92%   -0.08%     
==========================================
  Files          45       45              
  Lines        3483     3481       -2     
==========================================
- Hits         2473     2469       -4     
- Misses       1010     1012       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willguibr willguibr merged commit 75ae58f into master Nov 5, 2024
10 of 16 checks passed
Copy link

github-actions bot commented Nov 5, 2024

🎉 This PR is included in version 0.9.7 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
Status: 🚀 Shipped
1 participant