Fix variable scope warnings #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning has been founded by using Cppcheck 1.86. Signed-off-by: Ercan Ersoy <ercanersoy@ercanersoy.net>
These warnings have been founded by using Cppcheck 1.86. Signed-off-by: Ercan Ersoy <ercanersoy@ercanersoy.net>
Signed-off-by: Ercan Ersoy <ercanersoy@ercanersoy.net>
|
Breaks C89 compatibility. |
|
Some of those changes might make sense but I don't really see them as necessary. |
- Deleted unconditional integer variable definition on for loop. It is unneeded except JSMN_PARENT_LINKS option. - Added conditional integer variable definition before for loop. Signed-off-by: Ercan Ersoy <ercanersoy@ercanersoy.net>
|
Variable scope warnings can reduce optimizations. |
|
I don't see the point of those optimizations in the tests and doubt that the single redeclaration will matter on platforms targeted by JSMN. |
|
Cppcheck results of jsmn.h on your repository:
I have used Cppcheck 1.86. I have used this command line:
Reference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed variable scope warnings on jsmn.h, test/testc.c and test/testutil.h files.
These warnings have been founded by using Cppcheck 1.86.