-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accepting a line in isearch does not remove cursor imprint and partial path highlighting #284
Comments
m0vie
added a commit
to m0vie/zsh-syntax-highlighting
that referenced
this issue
Mar 29, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
Reproduction instructions at #259 (comment) |
m0vie
added a commit
to m0vie/zsh-syntax-highlighting
that referenced
this issue
Apr 2, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
m0vie
added a commit
to m0vie/zsh-syntax-highlighting
that referenced
this issue
Apr 10, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
m0vie
added a commit
to m0vie/zsh-syntax-highlighting
that referenced
this issue
Apr 16, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
m0vie
added a commit
to m0vie/zsh-syntax-highlighting
that referenced
this issue
Apr 24, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
m0vie
added a commit
to m0vie/zsh-syntax-highlighting
that referenced
this issue
Apr 29, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
PR: #288 |
m0vie
added a commit
to m0vie/zsh-syntax-highlighting
that referenced
this issue
Jun 11, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
m0vie
added a commit
to m0vie/zsh-syntax-highlighting
that referenced
this issue
Jun 20, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
m0vie
added a commit
to m0vie/zsh-syntax-highlighting
that referenced
this issue
Jun 20, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
danielshahaf
pushed a commit
to danielshahaf/zsh-syntax-highlighting
that referenced
this issue
Jul 27, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
danielshahaf
pushed a commit
to danielshahaf/zsh-syntax-highlighting
that referenced
this issue
Jul 27, 2016
Special handling for cursor imprint or partial path highlighting is needed in more cases than accept-*. For example when accepting a line from isearch, no accept-* widget is invoked. The proper way is to use zle-line-finish. Trumps zsh-users#259. Fixes zsh-users#284.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When accepting a line from within an isearch minimuffer, none of the
accept-*
widgets are called so the special handling for cursor imprint and partial path removal is not triggered.Should use
zle-line-finish
instead.The text was updated successfully, but these errors were encountered: