Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add app icon for macos #321

Merged
merged 1 commit into from
Jun 6, 2023
Merged

add app icon for macos #321

merged 1 commit into from
Jun 6, 2023

Conversation

mariodian
Copy link
Contributor

I propose this small change to the app's icon so it's more in line with Apple's design guidelines (added padding and shadow).

new macos icon

I left the original icon intact so the change doesn't affect Linux and Windows users.

I believe changes to window and tray in electron/index.cjs aren't necessary because:

  1. there's no window icon in any MacOS (only OSX which is fairly old)
  2. the app has no ability to be displayed in top menu bar currently (I assume that's what electron's Tray() is in MacOS)

If you want me to add the icon to window and tray though, I'm happy to do so.

Copy link
Owner

@ztjhz ztjhz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just need a new line at the end of the package.json file

package.json Outdated Show resolved Hide resolved
@ztjhz ztjhz merged commit 13ac535 into ztjhz:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants