Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gpt-4-0125-preview as a model option #521

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

DigitallyTailored
Copy link
Contributor

I've taken the pricing from https://openai.com/pricing which is the same as the current gpt-4-1106-preview

@solstice23
Copy link

For those who want to be automatically upgraded to new GPT-4 Turbo preview versions, we are also introducing a new gpt-4-turbo-preview model name alias, which will always point to our latest GPT-4 Turbo preview model.

@DigitallyTailored
Copy link
Contributor Author

For those who want to be automatically upgraded to new GPT-4 Turbo preview versions, we are also introducing a new gpt-4-turbo-preview model name alias, which will always point to our latest GPT-4 Turbo preview model.

That might be good as an additional feature and I would be using it if it were added, but there is a disconnect there where we would not be communicating which model version the user is using exactly, plus we would still need to update the token costs manually if it changes between versions.

src/constants/chat.ts Show resolved Hide resolved
DigitallyTailored

This comment was marked as duplicate.

@AETHER-ENGINEERS
Copy link

AETHER-ENGINEERS commented Jan 28, 2024 via email

@DigitallyTailored
Copy link
Contributor Author

@AETHER-ENGINEERS I don't think this is relavent to this PR. You might want to make a new issue to discuss.
FYI the API key is stored on the client side using localstorage and according to the sourcecode on GH only used when being checked, set and posting requests directly to OpenAI.

@ztjhz
Copy link
Owner

ztjhz commented Jan 30, 2024

@DigitallyTailored Why was the token length reverted back to 4096?

@DigitallyTailored
Copy link
Contributor Author

DigitallyTailored commented Jan 30, 2024

@ztjhz

@DigitallyTailored Why was the token length reverted back to 4096?

As per @NN1985 comment: #521 (comment)

The original 4096 appears to be correct.

@ztjhz ztjhz merged commit ecad41f into ztjhz:main Feb 2, 2024
@almagest21
Copy link

@ztjhz @DigitallyTailored First, thank you for the update on this matter.
However, when a token length of 4096 is specified, I am unable to input long text, which I was able to do successfully with the previous version (gpt-4-1106-preview).

I also tried running BetterChatGPT locally after I rewrote the constant in src/constants/chat.ts as follows, there are no errors when receiving API output:

export const modelMaxToken = {
  'gpt-3.5-turbo': 4096,
  'gpt-3.5-turbo-0301': 4096,
  'gpt-3.5-turbo-0613': 4096,
  'gpt-3.5-turbo-16k': 16384,
  'gpt-3.5-turbo-16k-0613': 16384,
  'gpt-3.5-turbo-1106': 16384,
  'gpt-3.5-turbo-0125': 16384,
  'gpt-4': 8192,
  'gpt-4-0314': 8192,
  'gpt-4-0613': 8192,
  'gpt-4-32k': 32768,
  'gpt-4-32k-0314': 32768,
  'gpt-4-32k-0613': 32768,
  'gpt-4-1106-preview': 128000,
//  'gpt-4-0125-preview': 4096,
  'gpt-4-0125-preview': 128000,
};

Is this still the correct value of 4096? Does gpt-4-0125-preview not accept long inputs like gpt-4-1106-preview version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants