-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gpt-4-0125-preview as a model option #521
Conversation
|
That might be good as an additional feature and I would be using it if it were added, but there is a disconnect there where we would not be communicating which model version the user is using exactly, plus we would still need to update the token costs manually if it changes between versions. |
So, my primary concern is the fact that our API keys will be sent through
the website and presumably stored. What's to prevent bad actors from using
our keys?
…On Thu, 25 Jan 2024 at 18:04, Luke Aaron ***@***.***> wrote:
I've taken the pricing from https://openai.com/pricing which is the same
as the current gpt-4-1106-preview
------------------------------
You can view, comment on, or merge this pull request online at:
#521
Commit Summary
- 42e0f54
<42e0f54>
Added gpt-4-0125-preview as a model option
File Changes
(2 files <https://github.com/ztjhz/BetterChatGPT/pull/521/files>)
- *M* src/constants/chat.ts
<https://github.com/ztjhz/BetterChatGPT/pull/521/files#diff-5991d1a42d0cf29dd25cd52fee80b0c81b0782d1c3351b728c2783a2fd824205>
(8)
- *M* src/types/chat.ts
<https://github.com/ztjhz/BetterChatGPT/pull/521/files#diff-149830263521dd5458cda6d3607035614de3c2d8c55a4784ac632891361601e7>
(2)
Patch Links:
- https://github.com/ztjhz/BetterChatGPT/pull/521.patch
- https://github.com/ztjhz/BetterChatGPT/pull/521.diff
—
Reply to this email directly, view it on GitHub
<#521>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAORNT6J4C7NKWDR6LV4FDLYQMFLPAVCNFSM6AAAAABCLPBXR6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYDCNBVGQ2DSNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@AETHER-ENGINEERS I don't think this is relavent to this PR. You might want to make a new issue to discuss. |
@DigitallyTailored Why was the token length reverted back to 4096? |
As per @NN1985 comment: #521 (comment) The original 4096 appears to be correct. |
@ztjhz @DigitallyTailored First, thank you for the update on this matter. I also tried running BetterChatGPT locally after I rewrote the constant in src/constants/chat.ts as follows, there are no errors when receiving API output:
Is this still the correct value of 4096? Does gpt-4-0125-preview not accept long inputs like gpt-4-1106-preview version? |
I've taken the pricing from https://openai.com/pricing which is the same as the current gpt-4-1106-preview