Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user choose formatter #4

Closed
wants to merge 1 commit into from

Conversation

bronzdoc
Copy link

Hi, i noticed i can't override the pre-set formatter.

When you pass the --format flag to rspec it just appends the formatter you want to use to what you have as default. It doesn't overwrite it, so no matter what format i choose it always showing the documentation format. It will be nice if people be available to choose which formatter to use.

@coveralls
Copy link

coveralls commented Mar 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c4143b4 on bronzdoc:let_user_choose_formatter into 69c7c49 on zuazo:master.

@coveralls
Copy link

coveralls commented Mar 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c4143b4 on bronzdoc:let_user_choose_formatter into 69c7c49 on zuazo:master.

@zuazo
Copy link
Owner

zuazo commented Mar 11, 2017

@bronzdoc thanks for the PR! 😉

Do you know if there is a way to change the default values without disabling the possibility of changing them later?

@bronzdoc
Copy link
Author

Hey @zuazo 🙂

Yes, you create a .rspec file with the content --format documentation for example, so you don't have to pass the --format flag everytime you run the specs. You can create this file at home directory level or at project level. (In dockerspec this only works if configuration file don't exists)

I don't know if that responds your question 😅

@zuazo
Copy link
Owner

zuazo commented Mar 11, 2017

@bronzdoc, thanks for quick answer.

What I would like to know is if there is a way to do it inside the dockerspec library, to avoid simply eliminating that code. I mean, if we can change default RSpec configuration values inside lib/dockerspec/rspec/configuration.rb .

If you do not know, I'll look to see if I can find a way.

@bronzdoc
Copy link
Author

Oh, yeah i don't know about that

@zuazo
Copy link
Owner

zuazo commented Mar 19, 2017

Fixed in master through 3483b59.

Thanks for your help!

@bronzdoc
Copy link
Author

Thanks @zuazo

@zuazo
Copy link
Owner

zuazo commented Mar 20, 2017

Released in 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants