Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pfx on windows fails due to CRLF conversion #19

Merged
merged 2 commits into from
Nov 22, 2015
Merged

Pfx on windows fails due to CRLF conversion #19

merged 2 commits into from
Nov 22, 2015

Conversation

taliesins
Copy link

Read certificates in way that CRLF conversion will not occur.

@zuazo
Copy link
Owner

zuazo commented Nov 16, 2015

Thanks @taliesins! 😃

Could you fix these little RuboCop offenses?

libraries/resource_ssl_certificate_readers.rb:72:35: C: Pass &:read as an argument to open instead of a block.
          ::File.open(path, 'rb') { |io| io.read }
                                  ^^^^^^^^^^^^^^^^

test/cookbooks/ssl_certificate_test/libraries/cert_ca_helper.rb:73:37: C: Pass &:read as an argument to open instead of a block.
    key = File.open(key_file, 'rb') { |io| io.read }
                                    ^^^^^^^^^^^^^^^^

zuazo added a commit that referenced this pull request Nov 22, 2015
@zuazo zuazo merged commit 944596e into zuazo:master Nov 22, 2015
@zuazo
Copy link
Owner

zuazo commented Nov 22, 2015

Merged. Style and unit tests fixed on 8858150.

Thanks for the contribution!

@zuazo
Copy link
Owner

zuazo commented Nov 23, 2015

Released in 1.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants