ADDED: Subject Alternate Names support for certs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @smeinel! Wonderful work! 😮 The change you have made in this PR is not at all easy to do. Documentation and tests included, nothing is missing. Just an aesthetic detail: Could you rename the |
|
Hi @zuazo I've made the changes and am currently running the tests. Once that's done, I'll rebase my branch and push it up. |
It is now possible to create certs that support multiple DNS names. ADDED: Tests for Subject Alternative Name feature UPDATED: README.md now includes documentation for the SAN feature
smeinel
force-pushed
the
feature-subject_alternate_names
branch
from
c410b74
to
93af924
Compare
|
OK, I've done a rebase and pushed the changes up to the PR branch. @zuazo please let me know if there are any further modifications needed. |
|
Excellent work! 😃 Thank you again. I'll let you know when I release it. |
zuazo
added a commit
that referenced
this pull request
Oct 27, 2014
ADDED: Subject Alternate Names support for certs
|
Released in 0.3.0. |
karlsvec
added a commit
to karlsvec/ssl_certificate-cookbook
that referenced
this pull request
Dec 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've been using your awesome cookbook lately, but for some of my servers, I needed to be able to have Subject Alternate Names support in my certs. Rather than asking you to add it, I figured it would be a good way to get better at Chef to add the feature myself. I'm submitting the PR to you in case you'd like to add it back into your cookbook.
Thanks!
It is now possible to create certs that support multiple DNS names.
ADDED: Tests for Subject Alternative Name feature
UPDATED: README.md now includes documentation for the SAN feature