-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADDED support for deploying an intermediate cert chain file #3
Conversation
Thanks again @smeinel. Seems OK. Give me a couple of days to review and test this carefully. |
when 'redhat', 'centos', 'fedora', 'scientific', 'amazon' | ||
'/etc/pki/tls/certs' | ||
else | ||
'/etc' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smeinel can you move this logic to an attribute file? I think it would be better there.
Are you referring to |
Yes, you are right. You've applied the same logic. I'm going to merge as it is. Cookbook code enhancements are outside this PR. Thanks! |
ADDED support for deploying an intermediate cert chain file
Thanks! Glad I could contribute. |
Released in 0.3.0. |
I seem to be having an issue when not specifying intermediate settings in the resource the recipe fails. When I then try it with an intermediate inside a data-bag it completes a chef-client. Any idea what I'm facing here? This is on ubuntu 14.04 My workaround is to specify the intermediate settings and just not use it after convergence. |
@benoahriz, seems to be a bug. Could you paste the error here? |
@zuazo I'll post the debug output as soon as I have some free cycles. Thanks. |
@benoahriz, I think I fixed your bug in 16bb02a. The error was something like Cannot read SSL intermediary chain from data bag. |
@benoahriz, fix for the chain bug released in |
@zuazo sorry for the late reply but the error message was when not specifying a chain
After upgrading to the 1.1.0 version I verified that it works as expected. Thanks so much! |
I'm glad your error is now fixed, @benoahriz. I really appreciate your feedback. Thanks! |
Hi, I've added support for optionally deploying an intermediate cert chain file along with the other cert files. Hopefully you'll find it useful & worth including!