Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDED support for deploying an intermediate cert chain file #3

Merged
merged 1 commit into from
Nov 3, 2014

Conversation

smeinel
Copy link
Contributor

@smeinel smeinel commented Oct 28, 2014

Hi, I've added support for optionally deploying an intermediate cert chain file along with the other cert files. Hopefully you'll find it useful & worth including!

@zuazo
Copy link
Owner

zuazo commented Oct 28, 2014

Thanks again @smeinel. Seems OK. Give me a couple of days to review and test this carefully.

when 'redhat', 'centos', 'fedora', 'scientific', 'amazon'
'/etc/pki/tls/certs'
else
'/etc'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smeinel can you move this logic to an attribute file? I think it would be better there.

@smeinel
Copy link
Contributor Author

smeinel commented Nov 3, 2014

Are you referring to default_chain_dir() ? I can do so if you like. I was simply aping the existing default_cert_dir() and used that as the basis for setting the correct directory. I'm still new to Chef and getting used to the coding conventions.

@zuazo
Copy link
Owner

zuazo commented Nov 3, 2014

Yes, you are right. You've applied the same logic. I'm going to merge as it is. Cookbook code enhancements are outside this PR. Thanks!

@zuazo zuazo self-assigned this Nov 3, 2014
zuazo added a commit that referenced this pull request Nov 3, 2014
ADDED support for deploying an intermediate cert chain file
@zuazo zuazo merged commit 78be9ab into zuazo:master Nov 3, 2014
@smeinel
Copy link
Contributor Author

smeinel commented Nov 3, 2014

Thanks! Glad I could contribute.

@zuazo
Copy link
Owner

zuazo commented Nov 3, 2014

Released in 0.3.0.

@smeinel smeinel deleted the chain_certs branch November 4, 2014 17:40
@benoahriz
Copy link

I seem to be having an issue when not specifying intermediate settings in the resource the recipe fails. When I then try it with an intermediate inside a data-bag it completes a chef-client. Any idea what I'm facing here? This is on ubuntu 14.04

My workaround is to specify the intermediate settings and just not use it after convergence.

@zuazo
Copy link
Owner

zuazo commented Dec 19, 2014

@benoahriz, seems to be a bug. Could you paste the error here?

@benoahriz
Copy link

@zuazo I'll post the debug output as soon as I have some free cycles. Thanks.

@zuazo
Copy link
Owner

zuazo commented Dec 27, 2014

@benoahriz, I think I fixed your bug in 16bb02a. The error was something like Cannot read SSL intermediary chain from data bag.

@zuazo
Copy link
Owner

zuazo commented Dec 30, 2014

@benoahriz, fix for the chain bug released in 1.0.0.

@benoahriz
Copy link

@zuazo sorry for the late reply but the error message was when not specifying a chain

 FATAL: Cannot read SSL intermediary chain from data bag: ssl.

After upgrading to the 1.1.0 version I verified that it works as expected. Thanks so much!

@zuazo
Copy link
Owner

zuazo commented Jan 2, 2015

I'm glad your error is now fixed, @benoahriz. I really appreciate your feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants