Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volumd slider for azan #2

Closed
wants to merge 2 commits into from
Closed

Conversation

flawlessx92
Copy link

No description provided.

Copy link
Owner

@zubir2k zubir2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salam. Good move introducing volume slider. Cuma, ni beberapa perkara perlu consideration:

  1. kena auto-add juga helper volume ni sama mcm helper lain kat dalam template tu.
  2. dalam lovelace, since slider ni hanya untuk google, kena guna conditional supaya kalau user pilih alexa, slider tu tak visible (unless slider ni boleh digunakan utk both).

@zubir2k
Copy link
Owner

zubir2k commented Oct 25, 2022

Salam,
After several testing, adding slider is not feasible as some media player does not support volume_level attributes.
Also to consider reverting back to original volume which can be achieved by adding a scene.

Thus, slider will not be merge into the release for now. Thank you for your time.

@zubir2k zubir2k closed this Oct 25, 2022
@zubir2k zubir2k added the wontfix This will not be worked on label Oct 25, 2022
@zubir2k
Copy link
Owner

zubir2k commented Aug 7, 2023

@flawlessx92 Volume slider implemented and the concern on attributes has been addressed. However. it is not fully tested on Amazon speakers. Please update your fork. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future-relase wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants