Skip to content

Commit

Permalink
share-to [nfc]: Convert a TODO-3918 comment to a TODO-server
Browse files Browse the repository at this point in the history
This is (as the comment already says) blocked behind a minimum-server
upgrade, so it's not really actionable on its own.  Instead, connect
the TODO to that upgrade.
  • Loading branch information
gnprice committed Mar 2, 2022
1 parent ca5bbfc commit 3375daf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/sharing/ShareWrapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { IconAttachment, IconCancel } from '../common/Icons';

type SendTo =
| {| type: 'pm', selectedRecipients: $ReadOnlyArray<UserId> |}
// TODO(#3918): Drop streamName. Used below for sending.
// TODO(server-2.0): Drop streamName (#3918). Used below for sending.
| {| type: 'stream', streamName: string, streamId: number, topic: string |};

const styles = createStyleSheet({
Expand Down Expand Up @@ -176,7 +176,7 @@ class ShareWrapperInner extends React.Component<Props, State> {
content: messageToSend,
type: 'stream',
subject: sendTo.topic || apiConstants.NO_TOPIC_TOPIC,
// TODO(server-2.0): switch to numeric stream ID, not name;
// TODO(server-2.0): switch to numeric stream ID (#3918), not name;
// then drop streamName from SendTo
to: sendTo.streamName,
};
Expand Down

0 comments on commit 3375daf

Please sign in to comment.