Skip to content

Commit

Permalink
settings: For subtitle of selected language, repeat canonical self-name
Browse files Browse the repository at this point in the history
It looks odd to have an item where the title and subtitle are
slightly different ways of naming the same thing. The canonical
self-name is the one we've chosen by following organizations
with a broad global contributor base like Wikipedia, so use that.

(We could instead just omit the subtitle, but if we did, then all
the rows in the list would have two lines of text except the
selected row which would have just one. And that non-uniformity
might look odd.)
  • Loading branch information
chrisbobbe authored and gnprice committed Mar 7, 2024
1 parent eba3566 commit 630caee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/settings/SettingsScreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export default function SettingsScreen(props: Props): Node {
items={languages.map(l => ({
key: l.tag,
title: noTranslation(l.selfname),
subtitle: l.name,
subtitle: l.tag === language ? noTranslation(l.selfname) : l.name,
}))}
onValueChange={value => {
dispatch(setGlobalSettings({ language: value }));
Expand Down

0 comments on commit 630caee

Please sign in to comment.