Skip to content

Commit

Permalink
accounts [nfc]: Point upgrade-refresh TODO at issue newly filed.
Browse files Browse the repository at this point in the history
And tighten the comment here, now that the details live there.
  • Loading branch information
gnprice committed Jun 11, 2021
1 parent 6e869c1 commit 807f6c1
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/account/accountsReducer.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,12 @@ export default (state: AccountsState = initialState, action: Action): AccountsSt
if (zulip_feature_level === undefined || zulip_version === undefined) {
return state;
}

// TODO: Detect if the feature level has changed, indicating an upgrade;
// if so, trigger a full refetch of server data. See #4793.
return [
{
...state[0],

// TODO (?): Detect if these are different from the values
// we had before, so we know it's an upgrade, not just a
// restart. Then, implement logic like "be sure to refetch
// from scratch within N hours" (to avoid thundering
// herding the server).
zulipVersion: new ZulipVersion(zulip_version),
zulipFeatureLevel: zulip_feature_level,
},
Expand Down

0 comments on commit 807f6c1

Please sign in to comment.