Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatars should be squares with rounded corners, not circles #205

Closed
timabbott opened this issue Jan 11, 2017 · 0 comments · Fixed by #208
Closed

Avatars should be squares with rounded corners, not circles #205

timabbott opened this issue Jan 11, 2017 · 0 comments · Fixed by #208
Assignees
@borisyankov
Labels
a-avatar Avatar URLs, caching, sizes, styles, etc. bug
Milestone
M4

Comments

@timabbott
Copy link
Member

Zulip's avatars should be displayed as squares (with rounded corners), not as circles.

This is based on a lot of consideration -- circular avatars are problematic because many images that we'd like to use in avatars (e.g. bot logos) don't actually look good in circular form, whereas just about anything looks good in a rounded square.
@timabbott timabbott added the bug label Jan 11, 2017
@timabbott timabbott added this to the M4 milestone Jan 11, 2017
@borisyankov borisyankov self-assigned this Jan 11, 2017
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jan 12, 2017
@borisyankov
Make all avatars square with rounded corners
324fd93 
Fixes zulip#205
@borisyankov borisyankov mentioned this issue Jan 12, 2017
Merged
borisyankov added a commit that referenced this issue Jan 15, 2017
@borisyankov
Make all avatars square with rounded corners
9dc8f09 
Fixes #205
@gnprice gnprice mentioned this issue Mar 12, 2019
Closed
gnprice added a commit that referenced this issue Mar 12, 2019
@gnprice
avatar: Make all avatars (rounded) squares, not circles.
805d35d 
Fixes #3398.  Zulip displays avatars as squares with rounded corners,
not circles, throughout the app on all platforms.  Among other
reasons, many avatar images don't work well when cropped to a circle;
among them many logos used for integrations, and even our own avatars
for Reminder Bot and its friends.

Importantly, we don't just tweak a prop at each call site: we
actually take out the code for the "circle" case.  In general, when
we decide we're not going to do things a certain way, leaving the old
no-longer-used code around causes confusion for anyone reading it;
and as this issue illustrates (compare 9dc8f09, fixing #205),
it can lead to silently re-introducing the behavior later.
@gnprice gnprice added the a-avatar Avatar URLs, caching, sizes, styles, etc. label Nov 12, 2020
@gnprice gnprice mentioned this issue Nov 12, 2020
Closed
@chrisbobbe chrisbobbe mentioned this issue Apr 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borisyankov borisyankov

Labels
a-avatar Avatar URLs, caching, sizes, styles, etc. bug
Projects
None yet
Milestone
M4
Development

Successfully merging a pull request may close this issue.

Make all avatars square with rounded corners borisyankov/zulip-mobile
3 participants
@gnprice @borisyankov @timabbott