Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depreciation warning for "PushNotificationIOS" module of core React-Native. #4510

Closed
Gautam-Arora24 opened this issue Mar 7, 2021 · 2 comments
Closed

Depreciation warning for "PushNotificationIOS" module of core React-Native. #4510

Gautam-Arora24 opened this issue Mar 7, 2021 · 2 comments
Labels
duplicate Task closed to consolidate with an equivalent task.

Comments

@Gautam-Arora24
Copy link
Contributor

Gautam-Arora24 commented Mar 7, 2021 •
edited
Loading

What is this issue for?
The core PushNotificationIOS module has been depreciated from React-Native. We can see this error in the console window when we start the server.
This is where official RN docs mention this.
Screenshot 2021-03-06 at 2 36 35 PM

Steps to solve this issue
We will use the react-native-community/push-notification-ios package. Instead of using PushNotificationIOS from react-native we will use the same from the above-mentioned package in /src/notification/index.js. The docs of the package mention the use of the PushNotificationIOS.
@Gautam-Arora24
Copy link
Contributor Author

Working on this!

Gautam-Arora24 added a commit to Gautam-Arora24/zulip-mobile that referenced this issue Mar 7, 2021
@Gautam-Arora24
deps: Use '@react-native-community/push-notification-ios'.
4123a15 
React-Native core 'PushNotificationIOS' module has been
depreciated.

The React-Native docs mentions to use one of the community
package called 'react-native-community/push-notification-ios'.

Used the above mentioned package to solve the depreciation
warning.
Fixes: zulip#4510
@Gautam-Arora24 Gautam-Arora24 mentioned this issue Mar 7, 2021
Closed
@chrisbobbe
Copy link
Contributor

Thanks, @Gautam-Arora24!

This deprecation warning is covered in issue #4115, which has PR #4163 open for it, so I'll go ahead and close this.

I probably could have done a better job of writing #4115, to include search terms like PushNotificationIOS, to make it easier for you to find; sorry about that. 🙂

@gnprice gnprice added the duplicate Task closed to consolidate with an equivalent task. label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Task closed to consolidate with an equivalent task.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: Use '@react-native-community/push-notification-ios'. Gautam-Arora24/zulip-mobile
3 participants
@gnprice @chrisbobbe @Gautam-Arora24