-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace notifications library with using platform APIs directly, on Android #2884
Commits on Aug 16, 2018
-
android gitignore: Add Android studio generated files to gitignore
Add android/app/{.classpath, .project & .settings} to gitignore
Configuration menu - View commit details
-
Copy full SHA for 8f95a9d - Browse repository at this point
Copy the full SHA 8f95a9dView commit details -
android notif: Replace ProxyService usage from library by a custom made
No functional change, implements the ProxyService from the library repo to Zulip project. This adds tools:node="remove" in the Manifest to remove the registration of service which is made by the wix notifications library The bundle passing is the same
Configuration menu - View commit details
-
Copy full SHA for 41877d8 - Browse repository at this point
Copy the full SHA 41877d8View commit details
Commits on Aug 22, 2018
-
android notif: Make notification data structure static
This would make sure there is only 1 instance running in the whole application and help in getting a reference of this object from files
Configuration menu - View commit details
-
Copy full SHA for ce8ed6b - Browse repository at this point
Copy the full SHA ce8ed6bView commit details -
android notif: Clear notifications in ProxyService
This moves the clearing of conversations in the ProxyService rather than the MainApplication and clears out a lot of logic from the MainApplication file Makes the converstaion LinkedHashMap a static object to have only 1 object of this data structure in the entire application and easily access this object in services
Configuration menu - View commit details
-
Copy full SHA for 166ecd5 - Browse repository at this point
Copy the full SHA 166ecd5View commit details -
android notif: Patch the manifest from the notifications library
Uses merge rule markers in the manifest to eliminate the services and receivers which were added by the library And implement the services in our AndroidManifest.xml. This is for removing the libary completely in the future commits
Configuration menu - View commit details
-
Copy full SHA for e0ff98a - Browse repository at this point
Copy the full SHA e0ff98aView commit details -
android notif: Implement GCM service to process the GCM messages
This is a service which extends GcmListenerService and recieves the incoming GCM messages and send the message to be displayed as a notification
Configuration menu - View commit details
-
Copy full SHA for db5442c - Browse repository at this point
Copy the full SHA db5442cView commit details -
android notif: Migrate the full notification builder logic from library
to custom implemented service. This has no visible changes only changes the service which was used to generate and display the notification.
Configuration menu - View commit details
-
Copy full SHA for 5f503a3 - Browse repository at this point
Copy the full SHA 5f503a3View commit details -
android notif: Use NotificationCompat instead of Notification
This would simplify the setSound conditional logic for different API versions.
Configuration menu - View commit details
-
Copy full SHA for 47da863 - Browse repository at this point
Copy the full SHA 47da863View commit details -
andorid notif: Implement GCM token refresher services
Generates GCM token using the sender ID stored in the AndroidManifest using an IntentService called GCMIdRefreshHandler. An additional service extended by InstanceIDListenerService is used to call the intent when the token is automatically updated by the google servers. In the JS side a function called refreshToken can be called via tha GcmTokenRefreshReactModule module and when the refresh process is completed, it is emitted into a notificationGcmTokenRefreshed event which can be collected in the JS module
Configuration menu - View commit details
-
Copy full SHA for 6cd9301 - Browse repository at this point
Copy the full SHA 6cd9301View commit details -
andorid notif: Narrow on pressed notification in the killed state
Notification is saved on the native threads and is recieved by the javascript thread by the getInitialNotification using the ZulipNotificationModule
Configuration menu - View commit details
-
Copy full SHA for 691dcc4 - Browse repository at this point
Copy the full SHA 691dcc4View commit details -
android notif: Narrow on pressed notification in the running state
On notification pressed while running state, java emits a notification bundle to the listener called `notificationOpened`
Configuration menu - View commit details
-
Copy full SHA for e095d5a - Browse repository at this point
Copy the full SHA e095d5aView commit details -
android notif: Remove dependencies for notifications library
Also removes the services which were patched in the manifest file
Configuration menu - View commit details
-
Copy full SHA for b6eee02 - Browse repository at this point
Copy the full SHA b6eee02View commit details