flow: Enable Types-First mode, on the path to RN v0.64 upgrade. #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it says in the comment, Flow has some trouble with the more
complex type in types-first mode. It would give some wrong-looking
errors:
Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ flow-typed/@react-navigation/stack_v5.x.x.js:844:22
object type [1] is incompatible with undefined [2] in the first argument. [incompatible-type]
flow-typed/@react-navigation/stack_v5.x.x.js
[2] 420│ declare type $IsUndefined<X> = $IsA<X, void>;
:
841│ +setOptions: (options: $Shape<ScreenOptions>) => void,
842│ +setParams: (
843│ params: $If<
844│ $IsUndefined<$ElementType<ParamList, RouteName>>,
845│ empty,
846│ $Shape<$NonMaybeType<$ElementType<ParamList, RouteName>>>,
847│ >,
src/nav/AppNavigator.js
[1] 53│ chat: RouteParamsOf<typeof ChatScreen>,
Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/chat/ChatScreen.js:113:57
Cannot call navigation.setParams with object literal bound to params because object literal [1] is incompatible with
empty [2]. [incompatible-call]
src/chat/ChatScreen.js
110│
111│ const { narrow, editMessage } = route.params;
112│ const setEditMessage = useCallback(
[1] 113│ (value: EditMessage | null) => navigation.setParams({ editMessage: value }),
114│ [navigation],
115│ );
116│
flow-typed/@react-navigation/stack_v5.x.x.js
[2] 843│ params: $If<
844│ $IsUndefined<$ElementType<ParamList, RouteName>>,
845│ empty,
846│ $Shape<$NonMaybeType<$ElementType<ParamList, RouteName>>>,
847│ >,
chrisbobbe
changed the title
chrisbobbe
force-pushed
the
pr-types-first
branch
from
d1cd090
to
c7ef99b
Compare
From Flow's perspective, we're fine to delay types-first until we're on v0.143, which we'd normally take along with the RN v0.65 upgrade. But, from experimentation, React Native v0.64's internal code seems to have been written with Types-First, such that a few Flow errors would show up if we tried to use RN v0.64 without Types-First enabled. So, enable it, now that we can, and now that the RN v0.64 upgrade is on the horizon (zulip#4426). Fixes: zulip#4907
chrisbobbe
force-pushed
the
pr-types-first
branch
from
c7ef99b
to
4774b91
Compare
|
🎊 Thanks! Looks good -- merging. |
|
Yay, thanks for the review! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Flow's perspective, we're fine to delay types-first until we're
on v0.143, which we'd normally take along with the RN v0.65 upgrade.
But, from experimentation, React Native v0.64's internal code seems
to have been written with Types-First, such that a few Flow errors
would show up if we tried to use RN v0.64 without Types-First
enabled. So, enable it, now that we can, and now that the RN v0.64
upgrade is on the horizon (#4426).
Fixes: #4907