RN v0.64 upgrade followups #4995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
reviewed
Sep 8, 2021
src/common/LoadingBanner.js
Outdated
| @@ -7,7 +7,7 @@ import { View } from 'react-native'; | |||
| import { useSelector } from '../react-redux'; | |||
| import { getLoading } from '../selectors'; | |||
| // eslint-disable-next-line import/no-useless-path-segments | |||
There was a problem hiding this comment.
This line can probably disappear too, right?
chrisbobbe
force-pushed
the
pr-rn-64-followups
branch
from
b7700bd
to
72bf129
Compare
|
Thanks for the review! Merged, with that fix. |
chrisbobbe
force-pushed
the
pr-rn-64-followups
branch
from
72bf129
to
d74fb12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these are all the planned followups, but I could be forgetting one or two. These just remove workarounds that are no longer necessary.
Related: #4426