android notifs: Fix regression where notifs dropped when avatar not fetched #5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-fetch-bitmap-null
branch
from
2a63f91
to
b27fc1f
Compare
…tched `IconCompat.createWithBitmap` [1] expects a non-null Bitmap object. Since abd605d, we've been directly passing the value returned from our own `fetchBitmap` function, which sometimes returns null. It seems like the symptom would be a failure to deliver a notification when the value is null. So, go back to not calling `IconCompat.createWithBitmap` unless we get a non-null value from `fetchBitmap`. See discussion at https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/sentry.20IllegalArgumentException.3A.20Bitmap.20must.20not.20be.20null.2E/near/1283842. [1] https://developer.android.com/reference/androidx/core/graphics/drawable/IconCompat#createWithBitmap(android.graphics.Bitmap)
This makes the boring parts of this pattern a bit more compact (just a single line at the start and another at the end), and the same as we do for the notification builders below.
gnprice
force-pushed
the
pr-fetch-bitmap-null
branch
from
b27fc1f
to
503b06a
Compare
|
Thanks for debugging and fixing this! Looks good -- merged, with a small formatting tweak on top. |
|
Thanks for the review and the formatting tweak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IconCompat.createWithBitmap[1] expects a non-null Bitmap object.Since abd605d, we've been directly passing the value returned from
our own
fetchBitmapfunction, which sometimes returns null. Itseems like the symptom would be a failure to deliver a notification
when the value is null.
So, go back to not calling
IconCompat.createWithBitmapunless weget a non-null value from
fetchBitmap.See discussion at
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/sentry.20IllegalArgumentException.3A.20Bitmap.20must.20not.20be.20null.2E/near/1283842.
[1] https://developer.android.com/reference/androidx/core/graphics/drawable/IconCompat#createWithBitmap(android.graphics.Bitmap)