Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump immutable range to ^4.0.0, from ^4.0.0-rc.15 #5375

Closed
wants to merge 1 commit into from

Conversation

chrisbobbe
Copy link
Contributor

This way, we'll get new 4.x releases when we do yarn upgrade.

The list of changes since 4.0.0-rc.15 is very short:
https://github.com/immutable-js/immutable-js/releases/tag/v4.0.0

"""

This way, we'll get new 4.x releases when we do `yarn upgrade`.

The list of changes since 4.0.0-rc.15 is very short:
  https://github.com/immutable-js/immutable-js/releases/tag/v4.0.0

  """
  - Ensure latest version docs are built by @leebyron in zulip#1877

  - Add correct types for empty Seq and Collection by @leebyron
    in zulip#1878

  - keep sidebar fixed + merge top and bottom sidebar by @jdeniau
    in zulip#1868

  - Changelog 4.0.0 by @bdurrer in zulip#1880
  """
@chrisbobbe chrisbobbe added the dependencies Pull requests that update a dependency file label May 6, 2022
@chrisbobbe chrisbobbe requested a review from gnprice May 6, 2022 22:14
@gnprice
Copy link
Member

gnprice commented May 10, 2022

Thanks! Change looks good -- comments only on the commit message.

  • It looks like there are live GitHub @-mentions in there; best to avoid those: https://github.com/zulip/zulip-mobile/blob/main/docs/style.md#mentioning-people

    Since you're quoting something with @-mentions in it, one solution would be to indent four spaces instead of two, so that GitHub treats it as verbatim text. … In fact, that would also be good for avoiding references like #1877 being interpreted as referring to this repo's issue/PR of the same number.

  • The summary says "from ^4.0.0-rc.15", but it looks like we actually have ^4.0.0-rc.12.

  • OTOH, the actual version in yarn.lock is already 4.0.0. So we don't even need to consider what the changes are since 4.0.0-rc.12 or 4.0.0-rc.15 -- the change is safe regardless.

  • "This way, we'll get new 4.x releases when we do yarn upgrade." -- Is this true? I'd have thought that ^4.0.0-rc.whatever permitted any non-prerelease 4.x release.

    And in fact (from git lsp -G immutable package.json yarn.lock), it seems like db7a18f / Migrate from Unimodules to Expo Modules #5203 did just that 🙂 , taking us to 4.0.0 with a yarn upgrade.

@chrisbobbe
Copy link
Contributor Author

And in fact (from git lsp -G immutable package.json yarn.lock), it seems like db7a18f / #5203 did just that 🙂 , taking us to 4.0.0 with a yarn upgrade.

Ah. 😝 I'll go ahead and close this, then. Thanks for the review!

@chrisbobbe chrisbobbe closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants