Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Run yarn upgrade #5411

Merged
merged 1 commit into from
Jun 13, 2022
Merged

deps: Run yarn upgrade #5411

merged 1 commit into from
Jun 13, 2022

Conversation

chrisbobbe
Copy link
Contributor

No description provided.

@chrisbobbe chrisbobbe requested a review from gnprice June 13, 2022 21:49
@gnprice
Copy link
Member

gnprice commented Jun 13, 2022

Thanks! Looks good; merging.

@gnprice gnprice merged commit 815d9f1 into zulip:main Jun 13, 2022
@gnprice
Copy link
Member

gnprice commented Jun 13, 2022

Looking at the remaining output of yarn outdated, I see there are a few identified as resolutionDependencies, i.e. where resolutions in our package.json is holding us on an older version. I'll look into upgrading node-gyp in particular:

node-gyp                            8.4.1             8.4.1   9.0.0   resolutionDependencies

as that resolutions line originated as a way to make it use a newer version, not an older one:
a7d19c0

@gnprice
Copy link
Member

gnprice commented Jun 13, 2022

I'll look into upgrading node-gyp in particular:

#5412.

@chrisbobbe chrisbobbe deleted the pr-yarn-upgrade branch June 13, 2022 22:28
@chrisbobbe
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants