Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: Make REGISTER_COMPLETE reset some state we forgot about #5613

Merged
merged 4 commits into from
Dec 29, 2022
Merged

model: Make REGISTER_COMPLETE reset some state we forgot about #5613

merged 4 commits into from
Dec 29, 2022

Commits on Dec 29, 2022

  1. fetching tests [nfc]: Avoid misleading initialState name

    @chrisbobbe
    chrisbobbe committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    06d2f84 View commit details
    Browse the repository at this point in the history

  2. fetching tests [nfc]: Tighten code style a bit

    @chrisbobbe
    chrisbobbe committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    692a881 View commit details
    Browse the repository at this point in the history

  3. fetching tests [nfc]: File an ungrouped test under MESSAGE_FETCH_COMP… 

    …LETE
    @chrisbobbe
    chrisbobbe committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    d88ec6a View commit details
    Browse the repository at this point in the history

  4. model: Make REGISTER_COMPLETE reset some state we forgot about 

    This addresses the second item in the list at zulip#5605:

> - [ ] `REGISTER_COMPLETE` should reset or replace all server data
>       and server-data metadata, but it isn't in some cases:
>       - server data: `topics`, `typing` (should reset)
>       - server-data metadata: `fetching` (should reset)

Although, I've left a comment on `fetchingReducer`, where doing so
felt a bit funny because morally it shouldn't be necessary.

Fixes-partly: zulip#5605
    @chrisbobbe
    chrisbobbe committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    77b7e9c View commit details
    Browse the repository at this point in the history