Revert "android: Update targetSdkVersion to 33 (Android 13)" #5752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f44474. From a user report, we found that we now have to handle a new runtime permission for notifications, and the consequence of not doing so is that notifications stop working on Android 13. Ouch; that would have been good to see mentioned in the "behavior changes" doc: https://developer.android.com/about/versions/13/behavior-changes-13#notification-permission-fgs-appearance Discussion (starting with the user report): https://chat.zulip.org/#narrow/stream/48-mobile/topic/.22This.20app.20does.20not.20send.20notifications.22/near/1634168
|
Thanks! Merging. |
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6f44474.
From a user report, we found that we now have to handle a new runtime permission for notifications, and the consequence of not doing so is that notifications stop working on Android 13. Ouch; that would have been good to see mentioned in the "behavior changes" doc:
https://developer.android.com/about/versions/13/behavior-changes-13#notification-permission-fgs-appearance
Discussion (starting with the user report):
https://chat.zulip.org/#narrow/stream/48-mobile/topic/.22This.20app.20does.20not.20send.20notifications.22/near/1634168