deps: Run yarn upgrade
#5756
Merged
deps: Run yarn upgrade
#5756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the |
gnprice
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Thanks for taking care of these! This is a big bundle of upgrades we've accumulated; good to be taking them.
The types changes look good. (I agree that if we did need to split things out, holding back react-native-safe-area-context would be a good strategy.)
One nit below, then please merge at will.
tools/tsflower
Outdated
| @@ -209,9 +209,11 @@ run_only() | |||
| rm -rf "${rootdir}"/types/"${package}"/lib/typescript/example/ | |||
| format_dir "${rootdir}"/types/"${package}" | |||
|
|
|||
| # Remove all *.web.js.flow files. We don't use RN for the web. | |||
| # Remove all *.web.js.flow files, *.windows.js.flow files, etc. | |||
There was a problem hiding this comment.
nit: can keep the "why" part of the comment:
Suggested change
| # Remove all *.web.js.flow files, *.windows.js.flow files, etc. | |
| # Remove all *.web.js.flow files, etc. We don't use RN on those platforms. |
chrisbobbe
force-pushed
the
pr-yarn-upgrade-2023-09-05
branch
from
2e61687
to
37faece
Compare
|
Thanks for the review! Merging, with that tweak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.