Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unknown users on profile and reactions-list screens #5790

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Handle unknown users on profile and reactions-list screens #5790

merged 6 commits into from
Nov 15, 2023

Commits on Nov 10, 2023

  1. user: Handle unknown user in AccountDetailsScreen 

    This is modeled on what we do in zulip-flutter (at ProfilePage),
but omitting the icon for expedience in this legacy codebase.
    @gnprice
    gnprice committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    80cf681 View commit details
    Browse the repository at this point in the history

  2. icon [nfc]: Generalize the name IconUserBlank, from IconUserMuted 

    The icon itself doesn't convey anything specific about "muted",
and we'll use it in another case shortly.
    @gnprice
    gnprice committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    a240ddb View commit details
    Browse the repository at this point in the history

  3. user [nfc]: Rearrange UserAvatar logic a bit 

    Making this into normal statement control flow, rather than
a `?:` operator, gives it more room to comfortably expand.
    @gnprice
    gnprice committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    64a21ac View commit details
    Browse the repository at this point in the history

  4. user: Render placeholder in UserAvatar for unknown user

    @gnprice
    gnprice committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    50afec8 View commit details
    Browse the repository at this point in the history

  5. user: Handle unknown user in UserItem

    @gnprice
    gnprice committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    5cde73f View commit details
    Browse the repository at this point in the history

  6. user [nfc]: Document the new preference for tryGetUserForId over thro… 

    …wing
    @gnprice
    gnprice committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    22672cd View commit details
    Browse the repository at this point in the history