Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifs: Warn about notifications soon to be disabled (not yet with banner) #5812

Merged
merged 5 commits into from
Jan 23, 2024
Merged

notifs: Warn about notifications soon to be disabled (not yet with banner) #5812

merged 5 commits into from
Jan 23, 2024

Commits on Jan 23, 2024

  1. types: Update GetText jsdoc for Hooks-based use 

    And drop the reference to withGetText, which we shouldn't need in a
Hooks-based world. Indeed that HOC isn't even used anymore; we'll
remove it next.
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5aa041f View commit details
    Browse the repository at this point in the history

  2. TranslationProvider [nfc]: Remove unused withGetText 

    It looks like our last use of this was removed in 8a0e486.
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    165b1d4 View commit details
    Browse the repository at this point in the history

  3. realm state: Add pushNotificationsEnabledEndTimestamp

    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0dabf13 View commit details
    Browse the repository at this point in the history

  4. reactUtils: Add and use useDateRefreshedAtInterval 

    We'll also start using this in useNotificationReportsByIdentityKey,
to check for a new NotificationProblem that will apply when the
server is about to stop enabling push notifications.
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cd1eebd View commit details
    Browse the repository at this point in the history

  5. notifs: Warn about notifications soon to be disabled (not yet with ba… 

    …nner)

Soon, we'll add a snoozable banner on the home screen. But for now:

- Warning icon / subtitle text on the "Notifications" row on the
  settings screen
- Warning row in the notification-settings screen
- Warning icon on the "Pick account" screen
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b30969b View commit details
    Browse the repository at this point in the history