Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android build: Update jsBundleDirRelease, fixing crash on startup #5824

Merged
merged 1 commit into from
Feb 27, 2024

Commits on Feb 27, 2024

  1. android build: Update jsBundleDirRelease for AGP 7.1+, fixing crash o…

    …n startup
    
    This is a new incarnation of the same underlying React Native
    issue seen in 8f8a266 and 833d083, back in 2019 and 2018
    respectively.  RN hard-codes what intermediate directory it
    expects the Android Gradle Plugin to look for assets in; but that
    directory isn't any kind of stable API, and in fact it changes
    from time to time in new versions of AGP.  It changed again
    in AGP 7.1.0.
    
    More recent versions of RN know about this latest change (with yet
    another hardcoding, conditioned on a new range of AGP versions):
      facebook/react-native#33057
    But ours doesn't, because we haven't been updating RN for a while in
    this legacy codebase.  So just update the directory we force it to.
    
    See discussion:
      https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/release.20build.20missing.20JS.20bundle/near/1746718
    
    [greg: expanded commit message]
    chrisbobbe authored and gnprice committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    eb56300 View commit details
    Browse the repository at this point in the history