ios: Disable Flipper #5848
Merged
ios: Disable Flipper #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-ios-disable-flipper
branch
from
0d777f0
to
cb4a07e
Compare
|
Thanks for cleaning this up! Looks good — merging. |
gnprice
force-pushed
the
pr-ios-disable-flipper
branch
from
cb4a07e
to
2cd2fbf
Compare
Our build times could probably have benefited from this for a while now; we never got into the habit of actually using Flipper. Flipper is a debugging tool. I believe its code has not been included in release builds. Anyway, disable it now, since things would otherwise be busted with recent Xcode, as mentioned in a comment. Done by commenting out the relevant line in the Podfile, and running `yarn` (resulting in a `pod install`) and doing a debug build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our build times could probably have benefited from this for a while now; we never got into the habit of actually using Flipper.
Anyway, do so now, since things would otherwise be busted with recent Xcode, as mentioned in a comment.