compose: Fix breakage of LaTeX delimiters in quote-and-reply #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
a-compose/send
|
Thanks! Looks good; merging. |
String.prototype.replace and String.prototype.replaceAll interpret certain sequences such as $$ within a string provided as the replacement argument. Because of this, LaTeX delimiters $$ were turning into $, and other sequences could duplicate part of the existing draft. Avoid this interpretation by providing a function. Fixes: zulip#5849
gnprice
force-pushed
the
pr-quote-and-reply-latex
branch
from
751a9ec
to
8140876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.prototype.replace and String.prototype.replaceAll interpret certain sequences such as $$ within a string provided as the replacement argument. Because of this, LaTeX delimiters $$ were turning into $, and other sequences could duplicate part of the existing draft.
Avoid this interpretation by providing a function.
Fixes: #5849